Initial support for a set of analyzers/fixers to update existing code to use collection expressions. #69118
Conversation
dotnet-issue-labeler
bot
added
Area-Analyzers
untriaged
…mabadi/roslyn into useCollectionExpression
| }); | ||
| } | ||
|
|
||
| private static bool IsInTargetTypedLocation(SemanticModel semanticModel, ExpressionSyntax expression, CancellationToken cancellationToken) |
There was a problem hiding this comment.
Will this suffer from many semantic model calls? I think the syntactic filteration would still have many applicable nodes, and hence many semantic model calls.
There was a problem hiding this comment.
Not sure what thsi question means.
There was a problem hiding this comment.
I mean, does this make too many semantic model caĺls that could affect performance?
There was a problem hiding this comment.
I don't see anything that would cause too many semantic model calls here. We effectively are doing a check right on the item of interest.
|
Example of results here: #69189 |
|
@dotnet/roslyn-ide ptal :) |
|
@dotnet/roslyn-ide ptal. |
| } | ||
|
|
||
| [Fact] | ||
| public async Task TestTargetTypedInConditional4() |
There was a problem hiding this comment.
| public async Task TestTargetTypedInConditional4() | |
| public async Task TestTargetTypedMissingInConditional4() |
There was a problem hiding this comment.
sure. can update that name in followup :)
ghost
added this to the 
Part of the work for: #69132
So i'm breaking things into pieces to make it easier to review.
This PR is specifically about handling
new X[] { a, b, c }ornew[] { a, b, c }orX[] v = { a, b, c }and offering to convert to[a, b, c]in those cases.