Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Complete ref readonly test plan #69474

Merged
merged 2 commits into from
Aug 14, 2023
Merged

Complete ref readonly test plan #69474

merged 2 commits into from
Aug 14, 2023

Conversation

jjonescz
Copy link
Member

Closes #68056.

  • Adds the remaining tests (more are in the other currently open ref readonly PRs).
  • Mentions ref readonly parameter modifier in the compiler test plan doc.

@dotnet-issue-labeler dotnet-issue-labeler bot added the untriaged Issues and PRs which have not yet been triaged by a lead label Aug 11, 2023
@jjonescz jjonescz marked this pull request as ready for review August 11, 2023 10:56
@jjonescz jjonescz requested a review from a team as a code owner August 11, 2023 10:56
@jjonescz jjonescz requested a review from jcouv August 11, 2023 10:56
@jcouv
Copy link
Member

jcouv commented Aug 11, 2023

Test/doc-only change can be merged with single review. Thanks

@jjonescz jjonescz merged commit 51e6508 into dotnet:main Aug 14, 2023
@jjonescz jjonescz deleted the RefReadonly-27-TestPlan branch August 14, 2023 10:26
@ghost ghost added this to the Next milestone Aug 14, 2023
@allisonchou allisonchou mentioned this pull request Aug 16, 2023
Closed
@dibarbet dibarbet modified the milestones: Next, 17.8 P2 Aug 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jaredpar jaredpar jaredpar approved these changes

@jcouv jcouv Awaiting requested review from jcouv

Assignees
No one assigned
Labels
Area-Compilers Feature - Ref Readonly Parameters `ref readonly` parameters untriaged Issues and PRs which have not yet been triaged by a lead
Projects
None yet
Milestone
17.8 P2
Development

Successfully merging this pull request may close these issues.

Test Plan: ref readonly
4 participants
@jjonescz @jcouv @jaredpar @dibarbet