Fix regression for suppressed diagnostics in Suggestion diagnostics tagger #69492
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…agger Fixes [AB#1869759](https://devdiv.visualstudio.com/DevDiv/_workitems/edit/1869759) This regressed with dotnet#68287, which enabled IDE0079 for LSP clients. I verified that the `SuggestionTagTest1` failed with `isSuppressed = true` prior to the product change in this PR. I also enhanced the DiagnosticSquiggleTaggerProvider test to validate the `isSuppressed = true` scenario, though those tests pass without the product change as that tagger provider already bailed out for suppressed diagnostics.
dotnet-issue-labeler
bot
added
Area-Analyzers
untriaged
mavasani
commented
Aug 14, 2023
| @@ -113,7 +116,7 @@ protected sealed override ITaggerEventSource CreateEventSource(ITextView? textVi | |||
|
|
|||
| foreach (var diagnosticData in diagnostics) | |||
| { | |||
| if (_callback.IncludeDiagnostic(diagnosticData)) | |||
| if (_callback.IncludeDiagnostic(diagnosticData) && !diagnosticData.IsSuppressed) | |||
There was a problem hiding this comment.
This is the product fix.
dibarbet
approved these changes
Aug 14, 2023
ghost
added this to the 
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes AB#1869759
This regressed with #68287, which enabled IDE0079 for LSP clients.
Testing
SuggestionTagTest1failed withisSuppressed = trueprior to the product change in this PR.DiagnosticSquiggleTaggerProvidertests to validate theisSuppressed = truescenario, though those tests pass without the product change as that tagger provider already bailed out for suppressed diagnostics.