Share common code in 'use collection expression'. #69502
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dotnet-issue-labeler
bot
added
Area-IDE
untriaged
CyrusNajmabadi
commented
Aug 14, 2023
| { | ||
| } | ||
|
|
||
| protected override void InitializeWorker(AnalysisContext context) | ||
| => context.RegisterCompilationStartAction(context => | ||
| protected override void InitializeWorker(CompilationStartAnalysisContext context) |
There was a problem hiding this comment.
view with whitespace off.
CyrusNajmabadi
commented
Aug 14, 2023
| .Add(s_descriptor, CodeStyleOptions2.PreferCollectionExpression) | ||
| .Add(s_unnecessaryCodeDescriptor, CodeStyleOptions2.PreferCollectionExpression)) | ||
| : base(IDEDiagnosticIds.UseCollectionExpressionForArrayDiagnosticId, | ||
| EnforceOnBuildValues.UseCollectionExpressionForArray) |
There was a problem hiding this comment.
each subclass needs to pass in these values to make sure the analyzer applies to it.
CyrusNajmabadi
commented
Aug 14, 2023
| { | ||
| if (!context.Compilation.LanguageVersion().SupportsCollectionExpressions()) | ||
| return; |
There was a problem hiding this comment.
base type does this check as it's common to all cases.
CyrusNajmabadi
commented
Aug 15, 2023
| protected override void InitializeWorker(CodeBlockStartAnalysisContext<SyntaxKind> context) | ||
| { | ||
| context.RegisterSyntaxNodeAction(AnalyzeArrayInitializerExpression, SyntaxKind.ArrayInitializerExpression); | ||
| context.RegisterSyntaxNodeAction(AnalyzeArrayCreationExpression, SyntaxKind.ArrayCreationExpression); |
There was a problem hiding this comment.
subtypes only ned to do this registration. all the outside parts are handled by the base type.
CyrusNajmabadi
commented
Aug 15, 2023
| context.RegisterSyntaxNodeAction(AnalyzeArrayCreationExpression, SyntaxKind.ArrayCreationExpression); | ||
| } | ||
|
|
||
| private void AnalyzeArrayCreationExpression(SyntaxNodeAnalysisContext context) |
There was a problem hiding this comment.
the descriptors are now instance state (As they are instance specific). so these methods became non-static.
akhera99
approved these changes
Aug 15, 2023
ghost
added this to the 
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.