Do not convert immutable arrays on downlevel runtimes #69520
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dotnet-issue-labeler
bot
added
Area-IDE
untriaged
CyrusNajmabadi
commented
Aug 15, 2023
| @@ -21,7 +21,7 @@ | |||
| <!-- Versions used by several individual references below --> | |||
| <RoslynDiagnosticsNugetPackageVersion>3.11.0-beta1.23364.2</RoslynDiagnosticsNugetPackageVersion> | |||
| <MicrosoftCodeAnalysisNetAnalyzersVersion>8.0.0-preview.23364.2</MicrosoftCodeAnalysisNetAnalyzersVersion> | |||
| <MicrosoftCodeAnalysisTestingVersion>1.1.2-beta1.23407.1</MicrosoftCodeAnalysisTestingVersion> | |||
| <MicrosoftCodeAnalysisTestingVersion>1.1.2-beta1.23411.1</MicrosoftCodeAnalysisTestingVersion> | |||
There was a problem hiding this comment.
needed so we get the right .net80 dlls that properly add the CollectionBuilderAttribute to the immutable collections.
akhera99
approved these changes
Aug 15, 2023
|
@CyrusNajmabadi Disabled auto-merge on this one to consider another option |
sharwell
reviewed
Aug 15, 2023
src/Analyzers/CSharp/Analyzers/UseCollectionExpression/UseCollectionExpressionHelpers.cs
Outdated
Show resolved
Hide resolved
sharwell
previously requested changes
Aug 15, 2023
CyrusNajmabadi
dismissed
sharwell’s stale review
Such a change can happen in a followup PR. This is the known bad case we have to fix asap.
sharwell
reviewed
Aug 15, 2023
src/Analyzers/CSharp/Tests/UseCollectionExpression/UseCollectionExpressionForCreateTests.cs
Outdated
Show resolved
Hide resolved
sharwell
approved these changes
Aug 15, 2023
ghost
added this to the 
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #69507