Add analyzer/fixer to suggest changing code fluent collection building to a collection expression #69580
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dotnet-issue-labeler
bot
added
Area-IDE
untriaged
Closed
14 tasks
|
@akhera99 for review. thanks! |
CyrusNajmabadi
commented
Aug 18, 2023
...nalyzers/UseCollectionExpression/CSharpUseCollectionExpressionForFluentDiagnosticAnalyzer.cs
Outdated
Show resolved
Hide resolved
…/CyrusNajmabadi/roslyn into useCollectionExpressionForFluent
CyrusNajmabadi
commented
Aug 18, 2023
| var conversion = speculationAnalyzer.SpeculativeSemanticModel.GetConversion(speculationAnalyzer.ReplacedExpression, cancellationToken); | ||
| if (conversion.IsIdentity) |
There was a problem hiding this comment.
@cston this appears to be an error. Once this merged, i'll open a bug on this.
CyrusNajmabadi
commented
Aug 18, 2023
| } | ||
|
|
||
| return node; | ||
| } |
There was a problem hiding this comment.
this improved indentation tracking in a few more situations.
CyrusNajmabadi
commented
Aug 19, 2023
CyrusNajmabadi
commented
Aug 21, 2023
| @@ -927,4 +926,87 @@ void M() | |||
| ReferenceAssemblies = ReferenceAssemblies.Net.Net80, | |||
| }.RunAsync(); | |||
| } | |||
|
|
|||
| [Fact] | |||
There was a problem hiding this comment.
beefed up testing in a few existing features.
CyrusNajmabadi
commented
Aug 21, 2023
| this.SyntaxFacts.GetNameAndArityOfSimpleName(memberName, out var name, out var arity); | ||
|
|
||
| if (arity != 0 || !Equals(name, methodName)) | ||
| return false; |
There was a problem hiding this comment.
moved the fast checks up.
|
@akhera99 ptal. |
akhera99
approved these changes
Aug 22, 2023
ghost
added this to the 
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of #69473
Finds code like:
ImmutableArray<int>.Empty.AddRange(x).AddRange(y).ToXXX()(and many patterns like that) and offers to convert to code like[..y, ..y].This works for varying patterns of
Add/AddRangeas well asConcat(on a reified list).