Keep as much parsed state as we can when producing frozen compilations #72184
Conversation
dotnet-issue-labeler
bot
added
Area-IDE
untriaged
|
@jasonmalinowski @ToddGrun this is ready for review. |
| return state switch | ||
| { | ||
| // If we don't have an existing state, then transition to a project state without any data. | ||
| null => this.ProjectState, |
There was a problem hiding this comment.
intentionally changes. teh RemoveAllDocuments is now in GetFrozenCompilationState
There was a problem hiding this comment.
If that's the case then update the comment.
There was a problem hiding this comment.
And at this point, I just want to see GetIniitalProjectState combined with the other function. There's now two functions that both have the same switches and you can only understand how this works if I look at both of them at once. It's far more cognitive load to understand the structure than just one bigger method here.
| @@ -641,35 +641,41 @@ public ICompilationTracker FreezePartialState(CancellationToken cancellationToke | |||
| if (state is FinalCompilationTrackerState { IsFrozen: true } finalState) | |||
| return this; | |||
|
|
|||
| var projectState = state switch | |||
There was a problem hiding this comment.
view with whitespace off.
| } | ||
| } | ||
|
|
||
| frozenProjectState = frozenProjectState.AddDocuments(documentsWithTrees.ToImmutableAndClear()); |
There was a problem hiding this comment.
i'd prefer to drive this based on allocation profiles. immutable types really help us ensure no mistakes.
| return state switch | ||
| { | ||
| // If we don't have an existing state, then transition to a project state without any data. | ||
| null => this.ProjectState, |
There was a problem hiding this comment.
And at this point, I just want to see GetIniitalProjectState combined with the other function. There's now two functions that both have the same switches and you can only understand how this works if I look at both of them at once. It's far more cognitive load to understand the structure than just one bigger method here.
src/Workspaces/Core/Portable/Workspace/Solution/SolutionCompilationState.CompilationTracker.cs
Outdated
Show resolved
Hide resolved
…ationState.CompilationTracker.cs Co-authored-by: Jason Malinowski <[email protected]>
No description provided.