Fix asserts when emitting calls with optional byref parameters #72203
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dotnet-issue-labeler
bot
added
Area-Compilers
untriaged
AlekseyTs
reviewed
Feb 22, 2024
| @@ -497,13 +497,13 @@ private BoundExpression MakeCallWithNoExplicitArgument(MethodArgumentInfo method | |||
| if (method.IsExtensionMethod) | |||
| { | |||
| Debug.Assert(expression == null); | |||
| Debug.Assert(method.Parameters.AsSpan()[1..].All(assertParametersAreOptional, (p, assertOptional) => (p.IsOptional || p.IsParams || !assertOptional) && p.RefKind == RefKind.None)); | |||
| Debug.Assert(method.ParameterRefKinds.IsDefaultOrEmpty || method.ParameterRefKinds[0] is RefKind.In or RefKind.RefReadOnlyParameter or RefKind.None); | |||
| Debug.Assert(method.Parameters.AsSpan()[1..].All(assertParametersAreOptional, static (p, assertOptional) => (p.IsOptional || p.IsParams || !assertOptional) && p.RefKind is RefKind.None or RefKind.In or RefKind.RefReadOnlyParameter)); | |||
There was a problem hiding this comment.
We will not be able to pass a reference to a "real" location to the call
We already warn at the declaration site if a ref readonly parameter has a default value. Also this PR is just fixing asserts, not changing behavior of the compiler in Release builds.
AlekseyTs
reviewed
Feb 22, 2024
| Debug.Assert(method.Parameters.AsSpan()[1..].All(assertParametersAreOptional, (p, assertOptional) => (p.IsOptional || p.IsParams || !assertOptional) && p.RefKind == RefKind.None)); | ||
| Debug.Assert(method.ParameterRefKinds.IsDefaultOrEmpty || method.ParameterRefKinds[0] is RefKind.In or RefKind.RefReadOnlyParameter or RefKind.None); | ||
| Debug.Assert(method.Parameters.AsSpan()[1..].All(assertParametersAreOptional, static (p, assertOptional) => (p.IsOptional || p.IsParams || !assertOptional) && p.RefKind is RefKind.None or RefKind.In or RefKind.RefReadOnlyParameter)); | ||
| Debug.Assert(method.ParameterRefKinds.IsDefaultOrEmpty || method.ParameterRefKinds.All(static refKind => refKind is RefKind.In or RefKind.RefReadOnlyParameter or RefKind.None)); |
AlekseyTs
reviewed
Feb 22, 2024
| { | ||
| public int Current { get; private set; } | ||
| public bool MoveNext() => Current++ != 3; | ||
| public void Dispose({{modifier}} int x = 5) { Console.Write("D"); } |
|
Done with review pass (commit 1) |
|
@dotnet/roslyn-compiler for a second review, thanks |
cston
approved these changes
Feb 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Discovered while investigating #72004.