Do all parsing work using InProgressState translation actions in the compilation tracker #72215
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CyrusNajmabadi
commented
Feb 23, 2024
src/Workspaces/Core/Portable/Workspace/Solution/SolutionCompilationState.CompilationTracker.cs
Outdated
Show resolved
Hide resolved
…ationState.CompilationTracker.cs
…roslyn into nullToInProgress
src/Workspaces/Core/Portable/Workspace/Solution/SolutionCompilationState.CompilationTracker.cs
Outdated
Show resolved
Hide resolved
src/Workspaces/Core/Portable/Workspace/Solution/SolutionCompilationState.CompilationTracker.cs
Outdated
Show resolved
Hide resolved
…ationState.CompilationTracker.cs Co-authored-by: Jason Malinowski <[email protected]>
jasonmalinowski
approved these changes
Feb 24, 2024
ToddGrun
reviewed
Feb 24, 2024
| // we'll see the results of how far we've gotten if someone asks for a frozen snapshot midway | ||
| // through. | ||
| var initialProjectState = this.ProjectState.RemoveAllDocuments(); | ||
| var initialCompilation = this.CreateEmptyCompilation(); |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes our work so that we don't up-front parse all files when transitioning from the null state to the initial inprogressstate. INstead, we just make an inprogressstate with a series of parsing actions within it.
This now cleanly allows us to transition to all files parsed, awhile also ensuring that any frozen snapshots that come along see those parsed documents.
also, we still attempt to do the work to parse all the files concurrently to get the benefits of multi-core.