Address cases where brace matching wasn't working for string quotes. #72233
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CyrusNajmabadi
commented
Feb 22, 2024
src/EditorFeatures/CSharpTest/AutomaticCompletion/AutomaticLiteralCompletionTests.cs
Show resolved
Hide resolved
CyrusNajmabadi
commented
Feb 22, 2024
| if (token.Kind() is not SyntaxKind.InterpolatedStringStartToken and | ||
| not SyntaxKind.InterpolatedVerbatimStringStartToken and | ||
| not SyntaxKind.StringLiteralToken and | ||
| not SyntaxKind.IdentifierToken) |
There was a problem hiding this comment.
prior logic was too much syntax tree based. this made it fall over when the tree wasn't well formed (like just having a naked $ in an expression).
The fix is to smartly moved before those characters. We then know we must have a string (since we have a $ and we know the user is typing "). We then use the existing helpers to then ask "is this a legal place for such a string".
Importantly, we're only looking at the tree prior to the current token we're writing. we're not trying to examine the in-progress token itself directly.
sharwell
approved these changes
Feb 22, 2024
src/Features/CSharp/Portable/BraceCompletion/InterpolatedStringBraceCompletionService.cs
Outdated
Show resolved
Hide resolved
|
Fixes #62571 if I understand this correctly |
…gBraceCompletionService.cs Co-authored-by: Sam Harwell <[email protected]>
Have done so. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #62571