Move test reference assemblies forward #73266
Conversation
dotnet-issue-labeler
bot
added
Area-Compilers
untriaged
|
@dotnet/roslyn-compiler PTAL |
| NetStandard20.mscorlib, | ||
| NetStandard20.netstandard, | ||
| NetStandard20.SystemRuntime, | ||
| NetStandard20.References.mscorlib, |
There was a problem hiding this comment.
nit: was looking at the code structure in the basic-reference-assemblies repo (for example), consider putting some xml doc comments on References and ReferenceInfos.
There was a problem hiding this comment.
Yeah looking at that code isn't going to be particularly useful. It's 99% just generated code.
XML docs are a good idea though. Will add those
There was a problem hiding this comment.
jaredpar/basic-reference-assemblies@5eeecbf
Those docs will show up next upgrade of these packages
| public static ImmutableArray<MetadataReference> MinimalReferences => ImmutableArray.Create(TestBase.MinCorlibRef); | ||
| public static ImmutableArray<MetadataReference> MinimalAsyncReferences => ImmutableArray.Create(TestBase.MinAsyncCorlibRef); | ||
| public static ImmutableArray<MetadataReference> Mscorlib45ExtendedReferences => ImmutableArray.Create<MetadataReference>(Net451.mscorlib, Net451.System, Net451.SystemCore, TestBase.ValueTupleRef, Net451.SystemRuntime); |
There was a problem hiding this comment.
Could we maintain the original order? That would make the diff more readable (easier to review)
There was a problem hiding this comment.
I moved the order specifically to line up with the comment. That comment is warning on the dangers of eagerly digging into TestBase. references as they are Lazy<T> based so we're kinda defeating things by eagerly digging in. This change groups all of the bundles that use TestBase. into a group, put them directly below the warning comment and use => to fulfill the "on demand" nature. All the ones in the second group do not depend on TestBase. and can be initialized more efficiently.
Perhaps I am misinterpreting the purpose of this change, but it doesn't look like we are adding ref assemblies for .Net 9. |
| public static ImmutableArray<MetadataReference> MinimalReferences => ImmutableArray.Create(TestBase.MinCorlibRef); | ||
| public static ImmutableArray<MetadataReference> MinimalAsyncReferences => ImmutableArray.Create(TestBase.MinAsyncCorlibRef); | ||
| public static ImmutableArray<MetadataReference> Mscorlib45ExtendedReferences => ImmutableArray.Create<MetadataReference>(Net451.mscorlib, Net451.System, Net451.SystemCore, TestBase.ValueTupleRef, Net451.SystemRuntime); | ||
| public static ImmutableArray<MetadataReference> Mscorlib46ExtendedReferences => ImmutableArray.Create<MetadataReference>(Net461.References.mscorlib, Net461.References.System, Net461.References.SystemCore, TestBase.ValueTupleRef, Net461.References.SystemRuntime); |
There was a problem hiding this comment.
Nit: why are these not collection expressions like the others?
There was a problem hiding this comment.
Cause I forgot to go back and change these 😄
This moves us to the latest version of our test reference assemblies. There is a bit of churn here because the API changed to be more efficient about how it loaded data.
There are a series of commits here:
TargetFrameworkUtilto be more readable. It was hard to maintain the invariants aroundTestBaselazy loading when all of the references were so far off the screen.