Move more code over to ProducerConsumer model. #73324
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dotnet-issue-labeler
bot
added
Area-IDE
untriaged
CyrusNajmabadi
commented
May 3, 2024
| @@ -120,14 +120,15 @@ private static void ClearCachedData() | |||
|
|
|||
| // Sort the groups into a high pri group (projects that contain a high-pri doc), and low pri groups (those that | |||
| // don't), and process in that order. | |||
| await PerformParallelSearchAsync( | |||
| await ProducerConsumer<RoslynNavigateToItem>.RunParallelAsync( | |||
There was a problem hiding this comment.
inlined as requested :)
CyrusNajmabadi
commented
May 3, 2024
| @@ -101,7 +101,7 @@ private static void ClearCachedData() | |||
| ImmutableArray<DocumentKey> priorityDocumentKeys, | |||
| string searchPattern, | |||
| IImmutableSet<string> kinds, | |||
| Func<ImmutableArray<RoslynNavigateToItem>, Task> onItemsFound, | |||
| Func<ImmutableArray<RoslynNavigateToItem>, VoidResult, CancellationToken, Task> onItemsFound, | |||
There was a problem hiding this comment.
need the VoidResult for the 'args'. we don't actually end up needing any args ourselves, so this is how we just indicate it's unused.
also, i found that things wer ecleaner if i made it so that 'cancellation' was consistently passed along as an actual arg to the lambdas, instead of needing to package it in the 'args' parameter.
CyrusNajmabadi
commented
May 3, 2024
| /// <code>Parallel.ForEachAsync</code>, allowing for parallel processing of the items, with a preference towards | ||
| /// earlier items. | ||
| /// </summary> | ||
| private static Task PerformParallelSearchAsync<T>( |
There was a problem hiding this comment.
removed. inlined in the 3 places that use it.
CyrusNajmabadi
commented
May 3, 2024
| @@ -94,19 +111,6 @@ internal static partial class FixAllContextHelper | |||
| return await GetDocumentDiagnosticsToFixAsync( | |||
| fixAllContext.Solution, allDiagnostics, fixAllContext.CancellationToken).ConfigureAwait(false); | |||
|
|
|||
| async Task AddDocumentDiagnosticsAsync(ConcurrentDictionary<ProjectId, ImmutableArray<Diagnostic>> diagnostics, Project projectToFix) | |||
ToddGrun
reviewed
May 3, 2024
| } | ||
| await foreach (var (project, diagnostics) in results) | ||
| { | ||
| if (diagnostics.Any()) |
There was a problem hiding this comment.
agreed. can do in followup.
|
@jasonmalinowski For review when you get back. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Followup to #73323.