Remove unused type #73352
Remove unused type #73352
Conversation
dotnet-issue-labeler
bot
added
Area-IDE
untriaged
| @@ -138,7 +137,6 @@ protected virtual void GetServices() | |||
| this.EditorOptionsService = this.Package.ComponentModel.GetService<EditorOptionsService>(); | |||
| this.Workspace = this.Package.ComponentModel.GetService<VisualStudioWorkspaceImpl>(); | |||
| this.EditorAdaptersFactoryService = this.Package.ComponentModel.GetService<IVsEditorAdaptersFactoryService>(); | |||
| this.AnalyzerFileWatcherService = this.Package.ComponentModel.GetService<AnalyzerFileWatcherService>(); | |||
There was a problem hiding this comment.
we would create the instance her.e HOwever:
- nothing ever read this feild in this type.
- the constructor for that type does nothing.
There was a problem hiding this comment.
i noticed this as i wanted to move these calls into the constructor of AbstractLangService, and i wanted to make sure none of them were doing anything wonky.
| [method: Obsolete(MefConstruction.ImportingConstructorMessage, error: true)] | ||
| internal sealed class AnalyzerFileWatcherService(SVsServiceProvider serviceProvider) | ||
| { | ||
| private readonly IVsFileChangeEx _fileChangeService = (IVsFileChangeEx)serviceProvider.GetService(typeof(SVsFileChangeEx)); |
There was a problem hiding this comment.
the constructor of this type does nothing except grab a service, which it places in a field, but never uses.
| } | ||
| } | ||
|
|
||
| internal void TrackFilePathAndReportErrorIfChanged(string filePath) |
There was a problem hiding this comment.
this is the only thing that could cause this type to do anything interesting. but it has no callers in roslyn. so this entire type is pointless.
removing. if someone can find a scenario where this is needed, we can return it. but we've clearly never noticed that it was doing nothing up till now.
|
@ToddGrun ptal. |
No description provided.