Fix issue with improper formatting in introduce-variable #73392
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dotnet-issue-labeler
bot
added
Area-IDE
untriaged
CyrusNajmabadi
commented
May 8, 2024
| document = await Formatter.FormatAsync(document, Formatter.Annotation, Options.FormattingOptions, cancellationToken).ConfigureAwait(false); | ||
| document = await CaseCorrector.CaseCorrectAsync(document, CaseCorrector.Annotation, cancellationToken).ConfigureAwait(false); | ||
| return document; | ||
| } |
There was a problem hiding this comment.
removing this method is the fix. it was trying to override the formatitng pass. however, my prior pr fixes things so that formatting happens at the right phase.
CyrusNajmabadi
commented
May 8, 2024
| @@ -5977,7 +5977,7 @@ void M() | |||
| { | |||
| int x = 1; | |||
| int {|Rename:y1|} = C.y; | |||
| var t = new { y= y1, y= y1 }; // this is an error already | |||
| var t = new { y = y1, y = y1 }; // this is an error already | |||
There was a problem hiding this comment.
old formatting was wrong here.
There was a problem hiding this comment.
includes changes from #73392. once that goes in, this won't be part of this pr.
CyrusNajmabadi
commented
May 8, 2024
| @@ -2,27 +2,22 @@ | |||
| // The .NET Foundation licenses this file to you under the MIT license. | |||
| // See the LICENSE file in the project root for more information. | |||
|
|
|||
| #nullable disable | |||
There was a problem hiding this comment.
view with whitespace off.
akhera99
approved these changes
May 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.