Optimize suppress operations during formatting. #73456
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dotnet-issue-labeler
bot
added
Area-IDE
untriaged
CyrusNajmabadi
commented
May 13, 2024
| @@ -58,6 +59,25 @@ internal static class ListExtensions | |||
| list.RemoveRange(targetIndex, list.Count - targetIndex); | |||
| } | |||
|
|
|||
| public static void RemoveOrTransformAll<T, TArg>(this ArrayBuilder<T> list, Func<T, TArg, T?> transform, TArg arg) | |||
There was a problem hiding this comment.
copy of the method above. just for ArrayBuilders.
CyrusNajmabadi
commented
May 13, 2024
| @@ -53,7 +55,6 @@ private class InitialContextFinder | |||
| if (initialSuppressOperations != null) | |||
| { | |||
| Debug.Assert( | |||
| initialSuppressOperations.IsEmpty() || | |||
There was a problem hiding this comment.
redundant with line below.
CyrusNajmabadi
commented
May 13, 2024
| @@ -176,6 +176,20 @@ private static void AddOperations<T>(SegmentedList<T> operations, List<T> scratc | |||
| scratch.Clear(); | |||
| } | |||
|
|
|||
| private static void AddOperations<T>(SegmentedList<T> operations, ArrayBuilder<T> scratch, SyntaxNode node, Action<ArrayBuilder<T>, SyntaxNode> addOperations) | |||
There was a problem hiding this comment.
copy of method above, just for array builders.
CyrusNajmabadi
commented
May 13, 2024
| var list = new List<SuppressOperation>(); | ||
| chainedFormattingRules.AddSuppressOperations(list, node); | ||
| return list; | ||
| } |
There was a problem hiding this comment.
not called at all.
ToddGrun
reviewed
May 13, 2024
| @@ -18,7 +19,7 @@ protected abstract class CompatAbstractMetadataFormattingRule : AbstractMetadata | |||
| #pragma warning disable CS0809 // Obsolete member overrides non-obsolete member | |||
| [Obsolete("Do not call this method directly (it will Stack Overflow).", error: true)] | |||
| [EditorBrowsable(EditorBrowsableState.Never)] | |||
| public sealed override void AddSuppressOperations(List<SuppressOperation> list, SyntaxNode node, in NextSuppressOperationAction nextOperation) | |||
| public sealed override void AddSuppressOperations(ArrayBuilder<SuppressOperation> list, SyntaxNode node, in NextSuppressOperationAction nextOperation) | |||
There was a problem hiding this comment.
maybe one more based on traces. but i'd like to do it one at a time, and based on need.
ToddGrun
reviewed
May 13, 2024
| } | ||
|
|
||
| // make sure we order align operation from left to right | ||
| alignmentOperation.Sort(static (o1, o2) => o1.BaseToken.Span.CompareTo(o2.BaseToken.Span)); |
This was referenced May 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Drops us from:
To: