Make the impl of SyntaxNode.GetText more efficient #73512
Conversation
dotnet-issue-labeler
bot
added
Area-Compilers
untriaged
| this.WriteTo(new StringWriter(builder)); | ||
| return new StringBuilderText(builder, encoding, checksumAlgorithm); | ||
| var fullWidth = this.Green.FullWidth; | ||
| var writer = SourceTextWriter.Create(encoding, checksumAlgorithm, fullWidth); |
There was a problem hiding this comment.
this helper gets an appropriate writer depending on the length of the final source text. For <85k (the loh limit) you get a simple string writer. For >85k you get a chunking writer.
| @@ -238,87 +236,6 @@ public static SourceText ReadFrom(ITextFactoryService textService, ObjectReader | |||
| return textService.CreateText(textReader, encoding, checksumAlgorithm, cancellationToken); | |||
| } | |||
|
|
|||
| public static SourceText CreateSourceText( | |||
There was a problem hiding this comment.
IDE impl that can be entirely removed now that the compiler side is just smarter.
There was a problem hiding this comment.
This also means we avoid the IDE making an entire copy of the node into our chunks, which then the compiler makes a copy of when making its LargeText instance itself.
| @@ -48,8 +48,7 @@ public override SourceText GetText(CancellationToken cancellationToken) | |||
| { | |||
| if (_lazyText == null) | |||
| { | |||
| var sourceText = SourceTextExtensions.CreateSourceText(GetRoot(cancellationToken), Encoding, _checksumAlgorithm, cancellationToken); | |||
| Interlocked.CompareExchange(ref _lazyText, sourceText, null); | |||
| Interlocked.CompareExchange(ref _lazyText, GetRoot(cancellationToken).GetText(Encoding, _checksumAlgorithm), null); | |||
There was a problem hiding this comment.
can just delegate to compiler, now that it is not inefficient.
|
@dotnet/roslyn-compiler for review. This is a tiny change in the impl here, with a big net win for IDE scenarios. BIG :D |
The existing impl woudl always allocation into the LOH for large trees. This manifested as huge growth in the LOH for normal IDE scenarios (like 'fix all'):
With this change, we drop to:
--
Total char[] allocs also drops from:
To: