Avoid searching entire trees when looking for implicit constructors in find-refs #73625
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dotnet-issue-labeler
bot
added
Area-IDE
untriaged
CyrusNajmabadi
changed the title
CyrusNajmabadi
commented
May 22, 2024
| return _identifierCache.GetOrAdd( | ||
| identifier, | ||
| identifier => FindMatchingIdentifierTokensFromTree(identifier, cancellationToken)); | ||
| } |
There was a problem hiding this comment.
this logic is the smae.
CyrusNajmabadi
commented
May 22, 2024
| identifier => FindMatchingTokensFromText( | ||
| identifier, | ||
| static (identifier, token, @this) => @this.IsMatch(identifier, token), | ||
| this, cancellationToken)); |
There was a problem hiding this comment.
this is almost hte same. just the addition of hte lambdaA+args to call nito a unified helper here.
ToddGrun
reviewed
May 22, 2024
| if (!state.Cache.SyntaxTreeIndex.ContainsImplicitObjectCreation) | ||
| return; | ||
|
|
||
| // Note: only C# supports implicit object creation. So we don't need to do anything special around case |
There was a problem hiding this comment.
it technically doesn't. it was just easier this way.
ToddGrun
reviewed
May 22, 2024
...kspaces/Core/Portable/FindSymbols/FindReferences/Finders/ConstructorSymbolReferenceFinder.cs
Outdated
Show resolved
Hide resolved
This was referenced Jun 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The current approach walks the whole tree for any file that we know has an implicit-object-creation expression in it (e.g.
new(...)). This is because we don't know what that expression will bind to, and we have to test each out.However, walkign the entire tree looking for these is unnecessary. We can instead search the docs containing such nodes for the
newtokens in them, and see if they start anew(...)node. This means we only have to walk those small subset of tokens. This addresses about 5% of the cost when doing a FAR on a named-type: