Fix leak of assembly metadata instances #73945
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dotnet-issue-labeler
bot
added
Area-IDE
untriaged
CyrusNajmabadi
commented
Jun 11, 2024
|
|
||
| // Cleanup when we hit powers of two. This way we don't have to walk too often. But only when we've really | ||
| // grown. the dictionary by a substantial amount since the last time we cleaned up. | ||
| if (count == (1 << SegmentedArraySortUtils.Log2((uint)count))) |
There was a problem hiding this comment.
this basically preserves the prior logic we had where we'd cleanup when we hit powers-of-two capacity. i don't love this approach. But it worked before, so i'm ok rolling back to that.
sharwell
approved these changes
Jun 11, 2024
| @@ -48,7 +50,7 @@ internal sealed partial class VisualStudioMetadataReferenceManager : IWorkspaceS | |||
| /// <summary> | |||
| /// Access locked with <see cref="_metadataCacheLock"/>. | |||
| /// </summary> | |||
| private readonly Dictionary<FileKey, AssemblyMetadata> _metadataCache = []; | |||
| private readonly Dictionary<FileKey, WeakReference<AssemblyMetadata>> _metadataCache = []; | |||
There was a problem hiding this comment.
💡 If you want to release the metadata as soon as nothing has a strong reference, but still have the cache, you can use ReferenceCountedDisposable<AssemblyMetadata>.WeakReference here. Not required, since leveraging that would require propagating RCD throughout the locations where these values are used.
This was referenced Jun 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes https://devdiv.visualstudio.com/DevDiv/_workitems/edit/1494103.
Issue introduced with #67470. In that PR i simplified code by removing several of our specialized ValueSource types. One that was used here was special in that it held onto the underlying data weakly. I failed to preserve the weak semantics with my change, leading to a leak as those assemblies changed on disk and we reloaded the assemblies.