Fix flaky test: LanguageServerCleansUpOnUnexpectedJsonRpcDisconnectAsync #73997
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dotnet-issue-labeler
bot
added
Area-IDE
untriaged
dibarbet
changed the title
Open
3 tasks
dibarbet
commented
Jun 17, 2024
|
|
||
| // Shutdown task will close the queue, so we need to wait for it to complete. | ||
| await shutdownTask.ConfigureAwait(false); | ||
| Assert.True(queueAccessor.IsComplete(), "Unexpected queue not complete"); |
There was a problem hiding this comment.
issue was that the shutdown task completes the queue, but this was not waiting for the shutdown task to complete (just verifying it started). This now waits for the shutdown task to complete.
dibarbet
changed the title
CyrusNajmabadi
approved these changes
Jun 17, 2024
This was referenced Jun 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #73977
Passed 400 iterations in CI (previously failed consistently ~20-30 times on that number)
