Ignore user-defined Span conversions #74002
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dotnet-issue-labeler
bot
added
Area-Compilers
untriaged
jjonescz
force-pushed
the
FirstClassSpan-05-IgnoreUdc
branch
2 times, most recently
from
7b3888d to
c9d1a8c
Compare
jjonescz
force-pushed
the
FirstClassSpan-05-IgnoreUdc
branch
from
c9d1a8c to
0a3b139
Compare
jjonescz
commented
Jun 25, 2024
333fred
reviewed
Jun 25, 2024
src/Compilers/CSharp/Portable/Binder/Semantics/Conversions/ConversionsBase.cs
Show resolved
Hide resolved
333fred
approved these changes
Jun 27, 2024
|
@cston for the second review, thanks |
cston
reviewed
Jun 28, 2024
| @@ -70,5 +70,6 @@ internal enum ConversionKind : byte | |||
| InlineArray, // A conversion from an inline array to Span/ReadOnlySpan | |||
|
|
|||
| ImplicitSpan, // A conversion between array, (ReadOnly)Span, string - part of the "first-class Span types" feature | |||
There was a problem hiding this comment.
Consider making the comment for ImplicitSpan more specific, to match the comment for ExplicitSpan. And I think the reference to the feature can be dropped. Perhaps:
// A conversion from array to (ReadOnly)Span, or from string or (ReadOnly)Span to ReadOnlySpan
cston
reviewed
Jun 28, 2024
| @@ -497,7 +509,7 @@ class C<T, U> | |||
|
|
|||
| var op = (IConversionOperation)model.GetOperation(cast)!; | |||
| var conv = op.GetConversion(); | |||
| Assert.Equal(ConversionKind.ImplicitSpan, conv.Kind); | |||
| Assert.Equal(ConversionKind.ExplicitSpan, conv.Kind); | |||
cston
reviewed
Jun 28, 2024
| } | ||
|
|
||
| [Fact] | ||
| public void Conversion_Array_ReadOnlySpan_Interface_Cast() |
cston
reviewed
Jun 28, 2024
| @@ -2426,6 +2577,19 @@ .maxstack 1 | |||
| IL_000b: ret | |||
| } | |||
| """); | |||
|
|
|||
| // Note: although a breaking change, the previous would fail with a runtime exception | |||
| // (Span's constructor checks that the element types are identical). | |||
There was a problem hiding this comment.
This definition of Span<T> does not contain a constructor.
cston
approved these changes
Jul 1, 2024
333fred
approved these changes
Jul 1, 2024
jjonescz
merged commit ab1b532
into
dotnet:features/FirstClassSpan
25 of 28 checks passed
This was referenced Oct 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Test plan: #73445
Corresponding speclet update: dotnet/csharplang#8167