Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add some missing LSP protocol definitions #74068

Merged
merged 1 commit into from
Jun 20, 2024
Merged

Add some missing LSP protocol definitions #74068

merged 1 commit into from
Jun 20, 2024

Conversation

dibarbet
Copy link
Member

Used by xaml

@dibarbet dibarbet requested a review from a team as a code owner June 20, 2024 00:06
@dotnet-issue-labeler dotnet-issue-labeler bot added Area-IDE untriaged Issues and PRs which have not yet been triaged by a lead labels Jun 20, 2024
@dibarbet dibarbet requested a review from mgoertz-msft June 20, 2024 00:06
mgoertz-msft
mgoertz-msft reviewed Jun 20, 2024
View reviewed changes
...nguageServer/Protocol/Protocol/Internal/VSInternalDocumentOnAutoInsertRegistrationOptions.cs
/// <summary>
/// Class representing the registration options for on auto insert support.
/// </summary>
internal class VSInternalDocumentOnAutoInsertRegistrationOptions : VSInternalDocumentOnAutoInsertOptions, ITextDocumentRegistrationOptions, IStaticRegistrationOptions
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I noticed that VSInternalDocumentOnAutoInsertOptions doesn't use JsonPropertyName but still DataMember. We need to update all of those as well so they serialize correctly.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mgoertz-msft hmm, it looks correct to me?
https://github.com/dotnet/roslyn/blob/main/src/LanguageServer/Protocol/Protocol/Internal/VSInternalDocumentOnAutoInsertOptions.cs

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hah, I see what happened. I made sure I was looking at main but I ended up in your fork :)

https://github.com/dibarbet/roslyn/blob/main/src/Features/LanguageServer/Protocol/Protocol/Internal/VSInternalDocumentOnAutoInsertOptions.cs

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's what I get for using the go to definition feature in a PR :)

This was referenced Jun 20, 2024
Open
Open
@build-analysis build-analysis bot mentioned this pull request Jun 20, 2024
Open
3 tasks
@dibarbet
Copy link
Member Author

/azp run roslyn-integration-CI

@azure-pipelines Azure Pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@dibarbet dibarbet merged commit adce315 into dotnet:main Jun 20, 2024
25 checks passed
@dibarbet dibarbet deleted the add_lsp_types branch June 20, 2024 22:03
@dotnet-policy-service dotnet-policy-service bot added this to the Next milestone Jun 20, 2024
@jjonescz jjonescz modified the milestones: Next, 17.11 P3 Jun 24, 2024
This was referenced Jun 26, 2024
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mgoertz-msft mgoertz-msft mgoertz-msft approved these changes

@JoeRobich JoeRobich JoeRobich approved these changes

Assignees
No one assigned
Labels
Area-IDE untriaged Issues and PRs which have not yet been triaged by a lead
Projects
None yet
Milestone
17.11 P3
Development

Successfully merging this pull request may close these issues.
4 participants
@dibarbet @JoeRobich @mgoertz-msft @jjonescz