-
Notifications
You must be signed in to change notification settings - Fork 4.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix param collection expression binding in expression trees #74166
Fix param collection expression binding in expression trees #74166
Conversation
We should may add a test for the concrete issue, too. I just created one for the root issue. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We don't want to bind differently in expression tree context. See https://github.com/dotnet/csharplang/blob/main/proposals/params-collections.md#expression-trees
Oh, then it becomes a breaking change to existing code. But this is wanted??? |
Please see https://github.com/dotnet/csharplang/blob/main/meetings/2024/LDM-2024-06-17.md#params-span-breaks for more information. |
I see - then we would need to fix the lowering (and use an array). |
Please see #74163 (comment). First, we need to understand the root cause of the problem. Where and what is going wrong. Only then we can decide what the fix should look like. I suggest you to start with that if you would like to continue working on the issue. |
We probably don't want to change the lowering in this fashion either. |
I wouldn't like to change the lowering code for interpolated string, too. |
Let's discuss possible fix strategies in the issue. While proposing a strategy, please make the proposal very specific and detailed. For example, the quote above looks neither specific, nor detailed to me. |
fixes: #74163