Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove (already disabled) command handlers related to 'add suppression' menu command. #74266

Merged
merged 7 commits into from
Jul 6, 2024
Merged
Show file tree
Hide file tree
Changes from 10 commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 0 additions & 7 deletions src/VisualStudio/Core/Def/ID.RoslynCommands.cs
Original file line number Diff line number Diff line change
Expand Up @@ -36,13 +36,6 @@ public static class RoslynCommands
public const int AddSuppressionsInSource = 0x011f;
public const int AddSuppressionsInSuppressionFile = 0x0120;
public const int RemoveSuppressions = 0x0121;
public const int ErrorListSetSeveritySubMenu = 0x0122;
public const int ErrorListSetSeverityError = 0x0124;
public const int ErrorListSetSeverityWarning = 0x0125;
public const int ErrorListSetSeverityInfo = 0x0126;
public const int ErrorListSetSeverityHidden = 0x0127;
public const int ErrorListSetSeverityNone = 0x0128;
public const int ErrorListSetSeverityDefault = 0x0129;
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Command ids no longer used.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: comment above could be updated


// Analyze and Code Cleanup menu IDs
public const int AnalysisScopeDefault = 0x0131;
Expand Down
2 changes: 0 additions & 2 deletions src/VisualStudio/Core/Def/RoslynPackage.cs
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,6 @@
using Microsoft.CodeAnalysis.Common;
using Microsoft.CodeAnalysis.EditAndContinue;
using Microsoft.CodeAnalysis.Editor.Implementation.IntelliSense.AsyncCompletion;
using Microsoft.CodeAnalysis.Editor.QuickInfo;
using Microsoft.CodeAnalysis.Editor.Shared.Utilities;
using Microsoft.CodeAnalysis.ErrorReporting;
using Microsoft.CodeAnalysis.Notification;
Expand Down Expand Up @@ -228,7 +227,6 @@ protected override async Task LoadComponentsAsync(CancellationToken cancellation
// we need to load it as early as possible since we can have errors from
// package from each language very early
await this.ComponentModel.GetService<VisualStudioSuppressionFixService>().InitializeAsync(this).ConfigureAwait(false);
await this.ComponentModel.GetService<VisualStudioDiagnosticListTableCommandHandler>().InitializeAsync(this, cancellationToken).ConfigureAwait(false);
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

no need to initialize since we have no more custom commands here.

await this.ComponentModel.GetService<VisualStudioDiagnosticListSuppressionStateService>().InitializeAsync(this, cancellationToken).ConfigureAwait(false);

await this.ComponentModel.GetService<IVisualStudioDiagnosticAnalyzerService>().InitializeAsync(this, cancellationToken).ConfigureAwait(false);
Expand Down

This file was deleted.

Loading
Loading