Rerun generators when an additional file is saved. #74542
Conversation
dotnet-issue-labeler
bot
added
Area-IDE
untriaged
| [Name(PredefinedCommandHandlerNames.SourceGeneratorSave)] | ||
| [ContentType(StandardContentTypeNames.Text)] |
There was a problem hiding this comment.
bleagh.
@jasonmalinowski @sharwell any ideas on this?
There was a problem hiding this comment.
@olegtk for thoughts as well. We only want to listen to saves when roslyn is actually loaded. but we do need to know about saves to files that aren't roslyn content type (like saving an xml file inside a roslyn project that will then have an impact on generators).
There was a problem hiding this comment.
Is RDT or another vs api a possibility here?
There was a problem hiding this comment.
Yeah listening to the RDT or some other VS would probably be what we need to do here.
There was a problem hiding this comment.
@jasonmalinowski anything i can look into?
There was a problem hiding this comment.
@CyrusNajmabadi maybe https://github.com/dotnet/roslyn/blob/main/src/VisualStudio/Core/Def/ProjectSystem/OpenTextBufferProvider.cs#L32
Looks like there is an OnAfterSave method we could implement
| [Name(PredefinedCommandHandlerNames.SourceGeneratorSave)] | ||
| [ContentType(StandardContentTypeNames.Text)] |
There was a problem hiding this comment.
This feels like its going to cause a lot of RPS regressions as this will now run on any content type. Can you do an RPS validation to check?
|
Thanks all. switched to RDT. |
| { | ||
| public string DisplayName => ServicesVSResources.Roslyn_save_command_handler; |
There was a problem hiding this comment.
will do in followup.
| [Export(typeof(ICommandHandler))] | ||
| [ContentType(ContentTypeNames.RoslynContentType)] | ||
| [ContentType(ContentTypeNames.XamlContentType)] | ||
| [Name(PredefinedCommandHandlerNames.SourceGeneratorSave)] |
There was a problem hiding this comment.
will do in followup.
CyrusNajmabadi
dismissed
dibarbet’s stale review
no longer using the Text content type.
Fixes #74395