Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Avoid optimizing away ref array access #74553

Merged
merged 6 commits into from
Aug 6, 2024
Merged

Avoid optimizing away ref array access #74553

merged 6 commits into from
Aug 6, 2024

Conversation

jjonescz
Copy link
Member

Fixes #73215.

@dotnet-issue-labeler dotnet-issue-labeler bot added Area-Compilers untriaged Issues and PRs which have not yet been triaged by a lead labels Jul 25, 2024
@jjonescz jjonescz marked this pull request as ready for review July 26, 2024 12:22
@jjonescz jjonescz requested a review from a team as a code owner July 26, 2024 12:22
@AlekseyTs
Copy link
Contributor

Done with review pass (commit 3)

AlekseyTs
AlekseyTs approved these changes Jul 26, 2024
View reviewed changes
Copy link
Contributor

@AlekseyTs AlekseyTs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM (commit 6)

@jjonescz jjonescz requested a review from a team July 29, 2024 08:05
@jjonescz
Copy link
Member Author

jjonescz commented Aug 1, 2024

@dotnet/roslyn-compiler for a second review, thanks

@jaredpar jaredpar added this to the 17.12 milestone Aug 4, 2024
@333fred
Copy link
Member

333fred commented Aug 5, 2024

/azp run roslyn-CI

@azure-pipelines Azure Pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@333fred
Copy link
Member

333fred commented Aug 5, 2024

Rerunning CI since it's been a week, will merge when green.

@333fred 333fred enabled auto-merge (squash) August 5, 2024 23:04
@333fred 333fred merged commit af73fba into dotnet:main Aug 6, 2024
24 checks passed
@dotnet-policy-service dotnet-policy-service bot modified the milestones: 17.12, Next Aug 6, 2024
This was referenced Aug 8, 2024
Closed
Closed
@dibarbet dibarbet modified the milestones: Next, 17.12 P2 Aug 26, 2024
@dotnet-bot dotnet-bot mentioned this pull request Aug 28, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AlekseyTs AlekseyTs AlekseyTs approved these changes

@333fred 333fred 333fred approved these changes

Assignees

@333fred 333fred

Labels
Area-Compilers untriaged Issues and PRs which have not yet been triaged by a lead
Projects
None yet
Milestone
17.12 P2
Development

Successfully merging this pull request may close these issues.

Roslyn codegen impacting array variance exception behavior
5 participants
@jjonescz @AlekseyTs @333fred @jaredpar @dibarbet