Allow more of Razor to use Roslyn Lsp types #74597
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dotnet-issue-labeler
bot
added
Area-IDE
untriaged
8 tasks
JoeRobich
approved these changes
Jul 30, 2024
davidwengier
force-pushed
the
RazorUsingMoreLspTypes
branch
from
a865562 to
4852886
Compare
|
/azp run |
|
Azure Pipelines successfully started running 3 pipeline(s). |
dibarbet
approved these changes
Oct 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Once Web Tools has moved to System.Text.Json, we on Razor can move off of Visual Studio Lsp types, which resolves a licensing mismatch in the C# extension. To do this, we just need a bit more access to the Roslyn Lsp types.
There was a couple of things missing, presumably added after forking, so I went ahead and added them, but only the minimum that Razor actually needs. Mikayla's PR probably already covers these too, and more obviously.