Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure that GetContentHash produces the same value on different endian machines #74696

Merged
merged 10 commits into from
Aug 9, 2024

Conversation

CyrusNajmabadi
Copy link
Member

@CyrusNajmabadi CyrusNajmabadi commented Aug 9, 2024

Fixes #74682

  1. We don't have a good way to test htis, absent a dedicated test run on a big endian machine (which is what the runtime team does).
  2. We can definitely take out that copy of the vectorized code, and say if you're before .net 8 that you get the slow impl.

@CyrusNajmabadi CyrusNajmabadi requested a review from a team as a code owner August 9, 2024 15:36
@dotnet-issue-labeler dotnet-issue-labeler bot added Area-Compilers untriaged Issues and PRs which have not yet been triaged by a lead labels Aug 9, 2024
@CyrusNajmabadi CyrusNajmabadi merged commit 2158b59 into dotnet:main Aug 9, 2024
24 checks passed
@CyrusNajmabadi CyrusNajmabadi deleted the reverseEndianness branch August 9, 2024 17:46
@dotnet-policy-service dotnet-policy-service bot added this to the Next milestone Aug 9, 2024
@dibarbet dibarbet modified the milestones: Next, 17.12 P2 Aug 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area-Compilers untriaged Issues and PRs which have not yet been triaged by a lead
Projects
None yet
Development

Successfully merging this pull request may close these issues.

The [InterceptsLocation] attribute generates a different "data" string for big-endian platforms
6 participants