Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow up to #74712
2 changes here:
SnippetContext
around byin
reference. The only actual data, thatSnippetContext
holds is 1 reference to aSyntaxContext
. Therefore passing it around byin
doesn't win anything, but adds unnecessary cognitive overhead when reading that codeSnippetContext
already holds aSyntaxContext
instance, all async work of getting syntax tree and semantic model from the document has already been done. Therefore it isn't practical to keep this path async. I remember there was a discussion, that semantic snippets engine is a potential candidate for becoming public API. And since there is no waySyntaxContext
become public, I additionaly exposedSemanticModel
as a public property ofSnippetContext
. That way a potential API user can get everything they need without having to deal with any async stuff:context.SemanticModel.SyntaxTree
context.SemanticModel.SyntaxTree.GetRoot()
context.SemanticModel
context.SemanticModel.Compilation