Fix issue where output path set in construction never updated the project update state #74791
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ution or project update state
dotnet-issue-labeler
bot
added
Area-IDE
untriaged
ryzngard
approved these changes
Aug 16, 2024
yup, seems to work in both cases |
CyrusNajmabadi
approved these changes
Aug 16, 2024
| @@ -164,6 +163,10 @@ await ApplyChangeToWorkspaceAsync(w => | |||
| onAfterUpdate: null); | |||
| }).ConfigureAwait(false); | |||
|
|
|||
| // Set this value early after solution is created so it is available to Razor. This will get updated | |||
There was a problem hiding this comment.
Not sure why Razor is being commented here -- this is just doing the thing the API is asking us to do....
There was a problem hiding this comment.
the early set was initially added for Razor here - 863962d
It does get set anyway later on when the cmdline is set.
src/Workspaces/Core/Portable/Workspace/ProjectSystem/ProjectSystemProjectFactory.cs
Show resolved
Hide resolved
dibarbet
changed the title
JoeRobich
reviewed
Aug 16, 2024
| @@ -164,6 +163,10 @@ await ApplyChangeToWorkspaceAsync(w => | |||
| onAfterUpdate: null); | |||
| }).ConfigureAwait(false); | |||
|
|
|||
| // Set this value early after solution is created so it is available to Razor. This will get updated | |||
| // when the command line is set, but we want a non-null value to be available as soon as possible. | |||
| project.CompilationOutputAssemblyFilePath = creationInfo.CompilationOutputAssemblyFilePath; | |||
There was a problem hiding this comment.
Could this have essentially been the only change needed here?
_projectUpdateState = _projectUpdateState.WithProjectOutputPath(creationInfo.CompilationOutputAssemblyFilePath, creationInfo.ProjectId);
There was a problem hiding this comment.
Possibly - but going through the same property setter as everything else feels safer.
jasonmalinowski
approved these changes
Aug 16, 2024
This was referenced Aug 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves dotnet/vscode-csharp#7402
863962d added support to set the backing field for
CompilationOutputAssemblyFilePathwhen creating theProjectSystemProject. This had an issue where the project update state ever observed this value as it did not go through appropriate setter onCompilationOutputAssemblyFilePathwhich is responsible for updating that.This caused us to later throw exceptions when attempting to remove that path as there was nothing to remove in the project update state.
I updated the code to instead update the path immediately after the
ProjectSystemProject(and the corresponding solution) was created, which resolves the issue on the test project linked in the issue.