Prioritize original user symbol in FAR results above cascaded symbols. #74805
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dotnet-issue-labeler
bot
added
Area-IDE
untriaged
CyrusNajmabadi
changed the title
CyrusNajmabadi
commented
Aug 19, 2024
| protected readonly List<Entry> EntriesWhenNotGroupingByDefinition = []; | ||
| protected readonly List<Entry> EntriesWhenGroupingByDefinition = []; | ||
| protected readonly (List<Entry> primary, List<Entry> nonPrimary) EntriesWhenNotGroupingByDefinition = ([], []); | ||
| protected readonly (List<Entry> primary, List<Entry> nonPrimary) EntriesWhenGroupingByDefinition = ([], []); |
There was a problem hiding this comment.
general idea is that we have 'entries' sorted into two sections. The 'primary' entries (those associated with the original symbol teh user is finding) and non-primary (those that came about from cascading).
CyrusNajmabadi
commented
Aug 19, 2024
| @@ -134,6 +134,9 @@ private StreamingFindUsagesPresenter( | |||
| public IClassificationFormatMap ClassificationFormatMap | |||
| => _lazyClassificationFormatMap.Value; | |||
|
|
|||
| private static bool IsPrimary(DefinitionItem definition) | |||
| => definition.Properties.ContainsKey(DefinitionItem.Primary); | |||
There was a problem hiding this comment.
we already had this data in the definitionItem. We were using it for other featuers. but hadn't updated FAR properly.
akhera99
approved these changes
Aug 19, 2024
Cosifne
approved these changes
Aug 19, 2024
This was referenced Aug 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes https://devdiv.visualstudio.com/DevDiv/_workitems/edit/2201415
Ensure that the initial symbol a user performs 'find all references' on is prioritized at the top of the FAR window (above all cascaded symbols):