-
Notifications
You must be signed in to change notification settings - Fork 4.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Semantic snippets tests #74808
Merged
Merged
Semantic snippets tests #74808
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…snippet test infrastructure
dotnet-issue-labeler
bot
added
Area-IDE
untriaged
Issues and PRs which have not yet been triaged by a lead
labels
Aug 19, 2024
dotnet-policy-service
bot
added
Community
The pull request was submitted by a contributor who is not a Microsoft employee.
VSCode
labels
Aug 19, 2024
@akhera99 PTAL |
akhera99
approved these changes
Aug 20, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks really good, thank you for your continued contributions in this space!
3 tasks
Someone restart failed pipelines pls |
This was referenced Aug 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #73909
Remade tests for semantic snippets from scratch:
SemanticSnippetCompletionProviderTests
. If we need to test that integration point more in the future, we can add new tests to this classEditorFeatures
toFeatures
layer{|0:placeholder|}
,{|1:placeholder2|}
etc.for
/forr
test instead of testingLength
andCount
property separately now use combinatorial data), some got renamed for consistency accross all semantic snippet tests[InlineData]
blocks