Workaround for InvalidOperationException thrown from EmitSolutionUpdateResults.GetAllDiagnosticsAsync #75011
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…-to-date when reporting rude edits
dotnet-issue-labeler
bot
added
Area-Interactive
untriaged
|
@davidwengier PTAL |
davidwengier
approved these changes
Sep 7, 2024
arunchndr
approved these changes
Sep 9, 2024
|
@tmat merge when ready. |
This was referenced Oct 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We were missing call to
WithUpToDateSourceGeneratorDocumentsin code paths that post-processed rude edits reported byEditAndContinueService. The service itself did callWithUpToDateSourceGeneratorDocumentson the solution snapshot it analyzed but the rude edits were post-processed on the snapshot that has not been updated with the latest source generator outputs. When the analysis found a rude edit in a document that has just been generated we did not find that document in the solution snapshot.Following up with a better fix that removes the post-processing step, but for servicing this workaround is more appropriate: #75013
Fixes https://devdiv.visualstudio.com/DevDiv/_workitems/edit/2169491