-
Notifications
You must be signed in to change notification settings - Fork 4.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: Fix "Augment user code" example #75041
Conversation
The generator generates a `Generated` attribute. Not `Generate`. Also added missing a closing paren.
@@ -223,7 +223,7 @@ Provide that attribute in a `RegisterPostInitializationOutput` step. Register fo | |||
```csharp | |||
public partial class UserClass | |||
{ | |||
[Generate] | |||
[Generated] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
❓ Should we also qualify this? Either with using GeneratedNamespace;
or as part of the attribute [GeneratedNamespace.Generated]
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, I think either would make it clearer.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I applied @sharwell's suggestion to the PR
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM Thanks (iteration 2)
Merged/squashed. Thanks @jfoshee for the contribution! |
The generator generates a
Generated
attribute. NotGenerate
. Also added missing a closing paren.