Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: Fix "Augment user code" example #75041

Merged
merged 2 commits into from
Oct 16, 2024
Merged

docs: Fix "Augment user code" example #75041

merged 2 commits into from
Oct 16, 2024

Conversation

jfoshee
Copy link
Contributor

@jfoshee jfoshee commented Sep 10, 2024

The generator generates a Generated attribute. Not Generate. Also added missing a closing paren.

The generator generates a `Generated` attribute. Not `Generate`.
Also added missing a closing paren.
@dotnet-issue-labeler dotnet-issue-labeler bot added Area-Compilers untriaged Issues and PRs which have not yet been triaged by a lead labels Sep 10, 2024
@dotnet-policy-service dotnet-policy-service bot added the Community The pull request was submitted by a contributor who is not a Microsoft employee. label Sep 10, 2024
@@ -223,7 +223,7 @@ Provide that attribute in a `RegisterPostInitializationOutput` step. Register fo
```csharp
public partial class UserClass
{
[Generate]
[Generated]
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

❓ Should we also qualify this? Either with using GeneratedNamespace; or as part of the attribute [GeneratedNamespace.Generated]?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, I think either would make it clearer.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I applied @sharwell's suggestion to the PR

Copy link
Member

@jcouv jcouv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM Thanks (iteration 2)

@jcouv jcouv merged commit ee941ff into dotnet:main Oct 16, 2024
5 checks passed
@dotnet-policy-service dotnet-policy-service bot added this to the Next milestone Oct 16, 2024
@jcouv
Copy link
Member

jcouv commented Oct 16, 2024

Merged/squashed. Thanks @jfoshee for the contribution!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area-Compilers Community The pull request was submitted by a contributor who is not a Microsoft employee. Documentation untriaged Issues and PRs which have not yet been triaged by a lead
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants