Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow OmniSharp to provide ImplementType Options #75312

Merged
merged 6 commits into from
Dec 19, 2024
Merged

Allow OmniSharp to provide ImplementType Options #75312

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
d638246
Remove OmniSharpCodeActionOptions
JoeRobich Dec 18, 2024
8f1a5c6
Give OmniSharp the ability to configure fallback analyzerconfigoptions
JoeRobich Dec 18, 2024
c791cde
Fixup
JoeRobich Dec 18, 2024
1a4a480
PR feedback
JoeRobich Dec 18, 2024
0688c73
Sort imports
JoeRobich Dec 18, 2024
11a6576
Switch to Workspace.TryApplyChanges
JoeRobich Dec 18, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 0 additions & 14 deletions src/Features/ExternalAccess/OmniSharp/CodeActions/OmniSharpCodeActionOptions.cs
View file
Open in desktop

This file was deleted.

9 changes: 0 additions & 9 deletions src/Features/ExternalAccess/OmniSharp/CodeActions/OmniSharpCodeFixContextFactory.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,19 +19,13 @@ public static CodeFixContext CreateCodeFixContext(
TextSpan span,
ImmutableArray<Diagnostic> diagnostics,
Action<CodeAction, ImmutableArray<Diagnostic>> registerCodeFix,
#pragma warning disable IDE0060 // Remove unused parameter
OmniSharpCodeActionOptions options,
#pragma warning restore IDE0060 // Remove unused parameter
CancellationToken cancellationToken)
=> new(document, span, diagnostics, registerCodeFix, cancellationToken);

public static CodeAnalysis.CodeRefactorings.CodeRefactoringContext CreateCodeRefactoringContext(
Document document,
TextSpan span,
Action<CodeAction, TextSpan?> registerRefactoring,
#pragma warning disable IDE0060 // Remove unused parameter
OmniSharpCodeActionOptions options,
#pragma warning restore IDE0060 // Remove unused parameter
CancellationToken cancellationToken)
=> new(document, span, registerRefactoring, cancellationToken);

Expand All @@ -44,9 +38,6 @@ public static FixAllContext CreateFixAllContext(
string? codeActionEquivalenceKey,
IEnumerable<string> diagnosticIds,
FixAllContext.DiagnosticProvider fixAllDiagnosticProvider,
#pragma warning disable IDE0060 // Remove unused parameter
Func<string, OmniSharpCodeActionOptions> optionsProvider,
#pragma warning restore IDE0060 // Remove unused parameter
CancellationToken cancellationToken)
=> new(new FixAllState(
fixAllProvider: NoOpFixAllProvider.Instance,
Expand Down
Loading
Loading