Fix servicehub symbol package name #75525
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dotnet-issue-labeler
bot
added
Area-IDE
untriaged
arunchndr
approved these changes
Oct 16, 2024
jaredpar
reviewed
Oct 16, 2024
| @@ -69,6 +69,11 @@ function Publish-Nuget($publishData, [string]$packageDir) { | |||
| throw "$nupkg does not exist" | |||
| } | |||
|
|
|||
| if ($nupkg.EndsWith(".symbols.nupkg")) { | |||
There was a problem hiding this comment.
Can we add a comment on how they are published if they aren't published here?
There was a problem hiding this comment.
tbh I'm still feeling perplexed on how our symbol publishing works. From the log, it seems we generate a bunch of {packageId}.Symbols.{version}.nupkg packages, then use *.symbols.nupkg to try to find them and failed to find any, therefore we copy those {packageId}.Symbols.{version}.nupkg to {packageId}*.Symbols.{version}.symbols.nupkg and use them instead... @tmat and I decided to at least have the name of these two servicehub packages right and figure out what to do for others later.
This was referenced Oct 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
hopefully this would fix the build. At least validation run is fixed