Add EmbeddedAttribute API for source generators #76583
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dotnet-issue-labeler
bot
added
Area-Compilers
untriaged
|
API review proposal: #76584. |
dotnet-policy-service
bot
added
the
Needs API Review
|
This PR modifies public API files. Please follow the instructions at https://github.com/dotnet/roslyn/blob/main/docs/contributing/API%20Review%20Process.md for ensuring all public APIs are reviewed before merging. |
333fred
force-pushed
the
add-generator-api
branch
from
5a6dca9 to
b33d913
Compare
Adds a new API to ensure that Microsoft.CodeAnalysis.EmbeddedAttribute is available in the compilation, and updates the cookbook to include information about using the attribute.
333fred
force-pushed
the
add-generator-api
branch
from
b33d913 to
5eed5e2
Compare
| @@ -76,6 +76,15 @@ internal override SyntaxTree ParseGeneratedSourceText(GeneratedSourceText input, | |||
|
|
|||
| internal override string SourceExtension => ".cs"; | |||
|
|
|||
| internal override string EmbeddedAttributeDefinition => """ | |||
| namespace Microsoft.CodeAnalysis | |||
There was a problem hiding this comment.
Nit. File scoped namespace
There was a problem hiding this comment.
I intentionally did not do this to maximize language version compat.
| internal override string EmbeddedAttributeDefinition => """ | ||
| namespace Microsoft.CodeAnalysis | ||
| { | ||
| internal sealed partial class EmbeddedAttribute : global::System.Attribute |
| } | ||
|
|
||
| [Fact] | ||
| public void IncrementalGenerator_PostInit_AddEmbeddedAttributeSource_DoubleAdd_Throws() |
There was a problem hiding this comment.
What if two separate generators both call this. Is it ok? Can there be a test for this
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a new API to ensure that Microsoft.CodeAnalysis.EmbeddedAttribute is available in the compilation, and updates the cookbook to include information about using the attribute.