Code

Metadata writer refactoring (3)#9459

Code

Closed

tmat wants to merge 85 commits intodotnet:masterdotnet/roslyn:masterfrom tmat:MetadataWriter-3tmat/roslyn:MetadataWriter-3Copy head branch name to clipboard

+8,394-6,350

Commits

Commits on Mar 20, 2016

• Dedup import scopes based on value equality instead of reference equality

  tmat

  committed
  eecc516

  Copy full SHA for eecc516

• Change IFieldDefinition.Offset type from uint to int

  tmat

  committed
  ca81b26

  Copy full SHA for ca81b26

• Use System.Reflection.Metadata.AssemblyFlags enum

  tmat

  committed
  c254c15

  Copy full SHA for c254c15

• Return ImmutableArray from IModule.GetResources

  tmat

  committed
  633cb11

  Copy full SHA for 633cb11

• Move tables and rows to a partial class

  tmat

  committed
  68ebec4

  Copy full SHA for 68ebec4

• Merge fixup

  tmat

  committed
  60c19ec

  Copy full SHA for 60c19ec

• Cleanup

  tmat

  committed
  69a98d5

  Copy full SHA for 69a98d5

• Move serialization methods

  tmat

  committed
  5a00120

  Copy full SHA for 5a00120

• Factor PE specific info out of MetadataSizes to PESizes

  tmat

  committed
  91a57d0

  Copy full SHA for 91a57d0

• CodedIndex helpers

  tmat

  committed
  41c36ed

  Copy full SHA for 41c36ed

• Move Populate methods around

  tmat

  committed
  169abb7

  Copy full SHA for 169abb7

• Add*

  tmat

  committed
  90a35c8

  Copy full SHA for 90a35c8

• Merge fixup

  tmat

  committed
  535f648

  Copy full SHA for 535f648

• Generic Parameters

  tmat

  committed
  8213a10

  Copy full SHA for 8213a10

• Sorting

  tmat

  committed
  eaffb24

  Copy full SHA for eaffb24

• EncTables and Capacity

  tmat

  committed
  eb5566c

  Copy full SHA for eb5566c

• DebugTables and GuidIdx

  tmat

  committed
  7cd0d02

  Copy full SHA for 7cd0d02

• Separate MetadataTablesBuilder from MetadataWriter

  tmat

  committed
  28595ba

  Copy full SHA for 28595ba

• Improve representation of sequence point in MDV

  tmat

  committed
  1b5f857

  Copy full SHA for 1b5f857

• Separate type-system and debug table builds

  tmat

  committed
  d98e8e6

  Copy full SHA for d98e8e6

• Clean up member flags

  tmat

  committed
  673d924

  Copy full SHA for 673d924

• Merge table and heap builders into MetadataBuilder

  tmat

  committed
  e5b61fd

  Copy full SHA for e5b61fd

• Move metadata builder to System.Reflection.Metadata.Ecma335 namespace

  tmat

  committed
  7b9c4d1

  Copy full SHA for 7b9c4d1

• Extract ManagedTextSection

  tmat

  committed
  5ced1a0

  Copy full SHA for 5ced1a0

• Switch .text section serialization to BlobBuilder

  tmat

  committed
  6751b2c

  Copy full SHA for 6751b2c

• Remove CorHeader class

  tmat

  committed
  45d05ce

  Copy full SHA for 45d05ce

• PEBuilder

  tmat

  committed
  85e0ad0

  Copy full SHA for 85e0ad0

• PeWriter cleanup

  tmat

  committed
  5cbd867

  Copy full SHA for 5cbd867

• Extract NativeResourceWriter

  tmat

  committed
  536cb95

  Copy full SHA for 536cb95

• Eliminate EncFuncCode in favor of EditAndContinueOperation

  tmat

  committed
  21f3f68

  Copy full SHA for 21f3f68

• Use LocalVariableAttributes enum instead of uint

  tmat

  committed
  1ee3898

  Copy full SHA for 1ee3898

• Use 'body offset' rather than 'rva' for offsets in IL stream, since they are not the final RVAs yet

  tmat

  committed
  13010b1

  Copy full SHA for 13010b1

• Custom modifiers in signatures are not allowed in general Type reference

  tmat

  committed
  4fa1b07

  Copy full SHA for 4fa1b07

• Attribute signature cleanup

  tmat

  committed
  8efdca1

  Copy full SHA for 8efdca1

• Extract primitive types to a method

  tmat

  committed
  9e0e6c7

  Copy full SHA for 9e0e6c7

• Custom attribute signatures

  tmat

  committed
  1c14f90

  Copy full SHA for 1c14f90

• Handling of arrays in CAs

  tmat

  committed
  4d26356

  Copy full SHA for 4d26356

• Cleanup IArrayTypeReference

  tmat

  committed
  40c2704

  Copy full SHA for 40c2704

• Remove treatRefAsPotentialTypeSpec parameter

  tmat

  committed
  10da4b2

  Copy full SHA for 10da4b2

• Restrict TypedReference

  tmat

  committed
  dd5d685

  Copy full SHA for dd5d685

• Method signature serialization cleanup

  tmat

  committed
  2454371

  Copy full SHA for 2454371

• Blob encoders

  tmat

  committed
  e5d9b8b

  Copy full SHA for e5d9b8b

• Renabe fields on MetadataWriter to avoid naming conflicts

  tmat

  committed
  05e754d

  Copy full SHA for 05e754d

• Change file layout to match S.R.M.

  tmat

  committed
  859e4e4

  Copy full SHA for 859e4e4

• Split SerializeMetadataAndIL

  tmat

  committed
  fb5f57a

  Copy full SHA for fb5f57a

• Split delta metadata, debug metadata and full metadata serialization

  tmat

  committed
  e625667

  Copy full SHA for e625667

• Factor machine related properties out from ModulePropertiesForSerialization, remove unused properties.

  tmat

  committed
  e34a937

  Copy full SHA for e34a937

• Inline MachineExtensions

  tmat

  committed
  dd8ffc2

  Copy full SHA for dd8ffc2

• CorFlags and DllCharacteristics

  tmat

  committed
  5964554

  Copy full SHA for 5964554

• Callback-based PE section serialization

  tmat

  committed
  b69e53d

  Copy full SHA for b69e53d

• Change BlobBuilder.ReserveBytes to return Blob instead of BlobWriter

  tmat

  committed
  a4134b9

  Copy full SHA for a4134b9

• Factor hashing of BlobBuilder content to a separate helper

  tmat

  committed
  ee3b281

  Copy full SHA for ee3b281

• Use Blobs for fixups

  tmat

  committed
  ae02b84

  Copy full SHA for ae02b84

• Inline SerializeManagedTextSection and SerializeStandaloneDebugMetadata.

  tmat

  committed
  c1c094d

  Copy full SHA for c1c094d

• Move ContentId to System.Reflection.PortableExecutable namespace

  tmat

  committed
  53ab3a7

  Copy full SHA for 53ab3a7

• Move managed PE section creation to ManagedPEBuilder

  tmat

  committed
  c74a417

  Copy full SHA for c74a417

• PEBuilder test

  tmat

  committed
  4ad9f0c

  Copy full SHA for 4ad9f0c

• Rename ImmutableArrayInterop type and methods to match names used in SRM

  tmat

  committed
  00dc7e3

  Copy full SHA for 00dc7e3

• Temporarily change namespaces for code that's transitioning to CoreFx

  tmat

  committed
  e39e25d

  Copy full SHA for e39e25d

• Use 1-based indices in GetTypeDef and GetMethodDef to be consistent with the rest of the methods

  tmat

  committed
  74a6b30

  Copy full SHA for 74a6b30

• Eliminated unreachable code branch in GetExportedTypeIndex -- the method returned wrong value but the code path was not reachable anyways; fix return value of GetFileRefIndex

  tmat

  committed
  3f35c09

  Copy full SHA for 3f35c09

• Replace ints with Handles

  tmat

  committed
  afdcacb

  Copy full SHA for afdcacb

• Replace XxxIdx with XxxHandle

  tmat

  committed
  3cdc2d5

  Copy full SHA for 3cdc2d5

• API renames

  tmat

  committed
  b7b5120

  Copy full SHA for b7b5120

• Move method body encoding to MethodBodyEncoder

  tmat

  committed
  75a9471

  Copy full SHA for 75a9471

• Introduce MethodBodyEncoder, ExceptionRegionEnconder and InstructionEncoder

  tmat

  committed
  69479c9

  Copy full SHA for 69479c9

• Reflect ECMA spec signature fixes

  tmat

  committed
  dee980b

  Copy full SHA for dee980b

• GetTypeHandle: remove duplicate code

  tmat

  committed
  c1e9213

  Copy full SHA for c1e9213

• Remove usage of tokens in favor of handles

  tmat

  committed
  5389965

  Copy full SHA for 5389965

• Rename methods

  tmat

  committed
  f58ae77

  Copy full SHA for f58ae77

• Fix namespace imports to avoid ambiguity between SRM types

  tmat

  committed
  781812b

  Copy full SHA for 781812b

• Merge fixup

  tmat

  committed
  65cd7fa

  Copy full SHA for 65cd7fa

• WriteCompressedInteger cleanup

  tmat

  committed
  bfbf506

  Copy full SHA for bfbf506

• Return handles from MetadataBuilder.Add- methods

  tmat

  committed
  9485bfb

  Copy full SHA for 9485bfb

• Simplify NamedArgumentsEncoder

  tmat

  committed
  418b6a2

  Copy full SHA for 418b6a2

• Make blob encoders non-generic

  tmat

  committed
  cb6a056

  Copy full SHA for cb6a056

• More tests

  tmat

  committed
  75ae328

  Copy full SHA for 75ae328

• Handle IOException from StrongNameProvider

  tmat

  committed
  887d5cf

  Copy full SHA for 887d5cf

• Merge fixup

  tmat

  committed
  ec5a2bf

  Copy full SHA for ec5a2bf

• Imports merge fixup

  tmat

  committed
  65d20ec

  Copy full SHA for 65d20ec

• Emit test merge fixup

  tmat

  committed
  a378285

  Copy full SHA for a378285

• Merge fixup

  tmat

  committed
  b2db64f

  Copy full SHA for b2db64f

• ImageFormatLimitationException

  tmat

  committed
  5bf79ca

  Copy full SHA for 5bf79ca

• Rename heap building GetXxx methods to GetOrAddXxx

  tmat

  committed
  dee4be8

  Copy full SHA for dee4be8

• Implement BranchBuilder

  tmat

  committed
  a1fbf0a

  Copy full SHA for a1fbf0a