Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added new string to be used by obsolete attributes. #984

Closed
wants to merge 2 commits into from

Conversation

EricArndt
Copy link

Currently having issues building so this is just a test to see if it works.

Currently having issues building so this is just a test to see if it works.
@dnfclas
Copy link

dnfclas commented Mar 3, 2015

Hi @EricArndt, I'm your friendly neighborhood .NET Foundation Pull Request Bot (You can call me DNFBOT). Thanks for your contribution!

In order for us to evaluate and accept your PR, we ask that you sign a contribution license agreement. It's all electronic and will take just minutes. I promise there's no faxing. https://cla2.dotnetfoundation.org.

TTYL, DNFBOT;

@dnfclas
Copy link

dnfclas commented Mar 3, 2015

@EricArndt, Thanks for signing the contribution license agreement so quickly! Actual humans will now validate the agreement and then evaluate the PR.

Thanks, DNFBOT;

End Get
End Property
End Class
End Namespace
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Did anything actually change here, or did the line endings or encoding accidentally get changed?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My local diff tool claimed that the files were identical. Git claimed that they were different. I was unable to reset the file and just ended up including it in the commit.

@dpoeschl
Copy link
Contributor

dpoeschl commented Mar 3, 2015

Tagging as a potential fix to #780

@EricArndt
Copy link
Author

retest this please

@Pilchie
Copy link
Member

Pilchie commented Mar 9, 2015

Closing per comments above. If we're going to address this, let's think about really addressing #711.

@Pilchie Pilchie closed this Mar 9, 2015
@davkean davkean added the Community The pull request was submitted by a contributor who is not a Microsoft employee. label Dec 16, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area-IDE Community The pull request was submitted by a contributor who is not a Microsoft employee.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants