Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

HTTP2 code coverage: add tests for DATA frame with PAD bit set #1503

Closed
geoffkizer opened this issue Jul 3, 2019 · 1 comment
Closed

HTTP2 code coverage: add tests for DATA frame with PAD bit set #1503

geoffkizer opened this issue Jul 3, 2019 · 1 comment
Labels
area-System.Net.Http test-enhancement Improvements of test source code
Milestone
9.0.0

Comments

@geoffkizer
Copy link
Contributor

Code coverage shows that we don't have any tests for this.

We should add tests that cover a few padding sizes -- 0, 1, etc.

Negative tests (pad length > frame length) would be good too, but are less of a priority.
@karelz karelz transferred this issue from dotnet/corefx Jan 9, 2020
@Dotnet-GitSync-Bot Dotnet-GitSync-Bot added the untriaged New issue has not been triaged by the area owner label Jan 9, 2020
@karelz karelz added area-System.Net.Http test-enhancement Improvements of test source code and removed untriaged New issue has not been triaged by the area owner labels Jan 9, 2020
@karelz karelz added this to the Future milestone Jan 9, 2020
MichalStrehovsky added a commit to MichalStrehovsky/runtime that referenced this issue Dec 9, 2021
@MichalStrehovsky
Update ObjectWriter NuGet (dotnet#1503)
07638f0 
We finally got a usable official build, so fix ObjWriter NuGet to match the source built one.
@ManickaP
Copy link
Member

Resolved by #99502

@github-actions github-actions bot locked and limited conversation to collaborators Apr 28, 2024
@karelz karelz modified the milestones: Future, 9.0.0 May 14, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
area-System.Net.Http test-enhancement Improvements of test source code
Projects
Networking ramp-up
Status: Done
Milestone
9.0.0
Development

No branches or pull requests
4 participants
@karelz @ManickaP @geoffkizer @Dotnet-GitSync-Bot