-
Notifications
You must be signed in to change notification settings - Fork 4.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
HTTP2: Two remote server tests occasionally timing out in CI #1580
Comments
I think it's probably this failing pr build: https://dev.azure.com/dnceng/public/_build/results?buildId=265300&view=ms.vss-test-web.build-test-results-tab&runId=7206096&resultId=100021 |
Yeah, that's one of the runs I saw. There was at least one other run on that PR (before I disabled the tests) that failed both as well. |
FWIW that failure is targeting the platform handler. |
Interesting. That would seem to point to the issue being either (a) CI slowness or (b) remote server slowness, as opposed to a product issue, since it seems to happen with different handlers. |
I don't think this blocks 3.0. Pushing out. |
What's the best way to address this issue going forward? The test failures are long gone from the build history so there's not much context. @geoffkizer should we maybe try re-enabling tests for HTTP2 and observe how they behave? |
@eiriktsarpalis are you working on it? If not, please unassign yourself. Thanks! |
Was working on this before my trip. Can confirm that the test is timing out consistently with the platform handler on linux CI, but it does not reproduce on my linux machine. |
Triage: either fix the tests or get rid of them or just disable them in CI, but run them locally if it's impossible to run in CI. |
These are tests I'm modifying to run with HTTP2 in dotnet/corefx#39343 but disabling for now.
Sometimes in CI, these tests timeout. Likely they are just running really slowly in CI and increasing the timeout would make them more reliable. We should investigate and confirm and change the timeout as appropriate.
PostAsync_RedirectWith307_LargePayload
PostRewindableContentUsingAuth_NoPreAuthenticate_Success
The text was updated successfully, but these errors were encountered: