-
Notifications
You must be signed in to change notification settings - Fork 4.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Stop dotnet/runtime from building NETStandard.Library.Ref 2.1.0? #2294
Comments
I think that sounds good, though I'd be curious to know what the plan is going forward for the Standard repo |
We're working through this. My expectation is that this repo will become similar to CoreFX/CoreCLR in that it's only used for servicing older releases and moving forward it'll be replaced by the runtime repo. However, this doesn't mean we need to build netstandard assets from the runtime repo. My expectation is that the |
Fixed with #33484 |
Reopening to discuss if we should delete the infra for this in dotnet/runtime as well, mainly this: https://github.com/dotnet/runtime/tree/master/src/installer/pkg/projects/netstandard @terrajobst any concerns about that? |
Closing - question of infra removal should go into its own issue. |
Right now, dotnet/runtime produces and publishes packages like
NETStandard.Library.Ref.2.1.0-alpha.1.20078.2.nupkg
from the official build.This isn't too unexpected: dotnet/runtime is responsible for creating NETStandard targeting packs until dotnet/standard is able to build them itself: dotnet/standard#1209.
I don't think we should be building version
2.1.0
though. #639 (comment):The simplest way to disable it is set the
ProjectServicingConfiguration PatchVersion="N/A"
. This avoids implying we know what vnext is for NETStandard. (See #2291 for details on the project disable infra.)@wtgodbe @terrajobst does this make sense?
/cc @NikolaMilosavljevic
The text was updated successfully, but these errors were encountered: