Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable producing NETStandard targeting pack in 5.0 branch #33208

Closed
NikolaMilosavljevic opened this issue Mar 5, 2020 · 3 comments
Closed
Labels
area-Infrastructure-installer untriaged New issue has not been triaged by the area owner

Comments

@NikolaMilosavljevic
Copy link
Member

Net Standard 2.1 packages (with preview branding) are still being produced in 5.0 branches.

This issue was fixed in 3.1 - issue #3800

Are we missing the fix in runtime repo?

@NikolaMilosavljevic NikolaMilosavljevic added area-Infrastructure-installer untriaged New issue has not been triaged by the area owner labels Mar 5, 2020
@Dotnet-GitSync-Bot
Copy link
Collaborator

I couldn't add an area label to this Issue.

Checkout this page to find out which area owner to ping, or please add exactly one area label to help train me in the future.

@dagood
Copy link
Member

dagood commented Mar 9, 2020

Duplicate of #2294

@dagood dagood marked this as a duplicate of #2294 Mar 9, 2020
@dagood dagood closed this as completed Mar 9, 2020
@dagood
Copy link
Member

dagood commented Mar 9, 2020

#3800 covers disabling targeting packs from building during servicing builds only. We don't disable targeting pack builds in general in master/preview branches because we expect constant API breaks. NETStandard is a special case because it doesn't quite fit in with the repo.

@ghost ghost locked as resolved and limited conversation to collaborators Dec 10, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
area-Infrastructure-installer untriaged New issue has not been triaged by the area owner
Projects
None yet
Development

No branches or pull requests

3 participants