Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Re-enable test GitHub_35821 #36418

Closed
kunalspathak opened this issue May 13, 2020 · 1 comment · Fixed by #38855
Closed

Re-enable test GitHub_35821 #36418

kunalspathak opened this issue May 13, 2020 · 1 comment · Fixed by #38855
Assignees
@sandreenko
Labels
area-CodeGen-coreclr CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI
Milestone
5.0.0

Comments

@kunalspathak
Copy link
Member

In #36206, the test GitHub_35821 fails. Once we fix the issue, we should re-enable the test.
@Dotnet-GitSync-Bot Dotnet-GitSync-Bot added area-Infrastructure-libraries untriaged New issue has not been triaged by the area owner labels May 13, 2020
@ghost
Copy link

ghost commented May 13, 2020

Tagging subscribers to this area: @safern, @ViktorHofer
Notify danmosemsft if you want to be subscribed.

@kunalspathak kunalspathak added area-CodeGen-coreclr CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI and removed area-Infrastructure-libraries labels May 13, 2020
@kunalspathak kunalspathak mentioned this issue May 13, 2020
Merged
@AndyAyersMS AndyAyersMS removed the untriaged New issue has not been triaged by the area owner label May 14, 2020
@AndyAyersMS AndyAyersMS added this to the 5.0 milestone May 14, 2020
sandreenko pushed a commit to sandreenko/runtime that referenced this issue Jul 7, 2020
Reenable GitHub_35821.
c31f691 
Closes dotnet#36206, closes dotnet#36418.

The issue was fixed by dotnet#37499.
@sandreenko sandreenko mentioned this issue Jul 7, 2020
Merged
sandreenko pushed a commit that referenced this issue Jul 8, 2020
Reenable fixed tests after noRetyping and similar changes. (#38855)
9bb997b 
* Reenable GitHub_26491.

Closes #13355

* Reenable crossgen2 tests failing with old retyping/

They were fixed both with and without retyping.
Closes #37883.

* Reenable HVA merge cases.

Closes #37341, closes #37880.

* Reenable GitHub_35821.

Closes #36206, closes #36418.

The issue was fixed by #37499.

* Delete extra lines that are no longer needed.

#37506 was fixed in #38241.

* delete a throwing init.
@ghost ghost locked as resolved and limited conversation to collaborators Dec 9, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@sandreenko sandreenko

Labels
area-CodeGen-coreclr CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI
Projects
None yet
Milestone
5.0.0
Development

Successfully merging a pull request may close this issue.

Reenable fixed tests after noRetyping and similar changes. sandreenko/runtime
4 participants
@AndyAyersMS @kunalspathak @sandreenko @Dotnet-GitSync-Bot