Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix initlocals handling with mono interpreter #37955

Closed
BrzVlad opened this issue Jun 16, 2020 · 2 comments
Closed

Fix initlocals handling with mono interpreter #37955

BrzVlad opened this issue Jun 16, 2020 · 2 comments

Comments

@BrzVlad
Copy link
Member

BrzVlad commented Jun 16, 2020

Normally, we are too conservative, adding a MINT_INITLOCALS opcode even if all locals are initialized by IL code, which should be the common case anyway. However, we are not initializing locals coming from inlined methods.

We should be able to detect in the future when an uninitialized local is being used, and only then add the initlocals, both in the inlined method and normal case.

Failed tests: JIT/Directed/zeroinit/**

@ghost
Copy link

ghost commented Jun 16, 2020

Tagging subscribers to this area: @BrzVlad, @lewurm
Notify danmosemsft if you want to be subscribed.

@Dotnet-GitSync-Bot Dotnet-GitSync-Bot added the untriaged New issue has not been triaged by the area owner label Jun 16, 2020
@BrzVlad BrzVlad removed the untriaged New issue has not been triaged by the area owner label Jun 16, 2020
@BrzVlad BrzVlad added this to the 6.0.0 milestone Jun 22, 2020
@BrzVlad BrzVlad modified the milestones: 6.0.0, Future Jun 2, 2021
@BrzVlad BrzVlad modified the milestones: Future, 8.0.0 Aug 2, 2022
@BrzVlad BrzVlad modified the milestones: 8.0.0, 9.0.0 Jul 10, 2023
@BrzVlad
Copy link
Member Author

BrzVlad commented Feb 13, 2024

Fixed in #96315

@BrzVlad BrzVlad closed this as completed Feb 13, 2024
@github-actions github-actions bot locked and limited conversation to collaborators Mar 16, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

2 participants