Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[wasm] broken .locals init #71425

Closed
pavelsavara opened this issue Jun 29, 2022 · 4 comments
Closed

[wasm] broken .locals init #71425

pavelsavara opened this issue Jun 29, 2022 · 4 comments
Assignees
@BrzVlad
Labels
arch-wasm WebAssembly architecture area-System.Runtime.InteropServices.JavaScript
Milestone
7.0.0

Comments

@pavelsavara
Copy link
Member

pavelsavara commented Jun 29, 2022 •
edited
Loading

New unit test System.Runtime.InteropServices.JavaScript.Tests.JavaScriptTests
showing that it takes 1000 calls to JS to expose un-initialised out int something argument on icall.
Only when in Release and with [MethodImpl(MethodImplOptions.AggressiveInlining)]

Repro #71387

log trace

  info: mono_wasm_do_nothing ptr: 46277408 value: 0
  info: I 997
  info: mono_wasm_do_nothing ptr: 46277408 value: 0
  info: I 998
  info: mono_wasm_do_nothing ptr: 46277408 value: 0
  info: I 999
  info: mono_wasm_do_nothing ptr: 46277360 value: 999

Note the change of the pointer on the last line.
@pavelsavara pavelsavara added this to the 7.0.0 milestone Jun 29, 2022
@ghost
Copy link

ghost commented Jun 29, 2022

Tagging subscribers to 'arch-wasm': @lewing
See info in area-owners.md if you want to be subscribed.

Issue Details

New unit test System.Runtime.InteropServices.JavaScript.Tests.JavaScriptTests
showing that it takes 1000 calls to JS to expose un-initialised out int something argument on icall.
Only when in Release and with [MethodImpl(MethodImplOptions.AggressiveInlining)]

Repro #71387

log trace

  info: mono_wasm_do_nothing ptr: 46277408 value: 0
  info: I 997
  info: mono_wasm_do_nothing ptr: 46277408 value: 0
  info: I 998
  info: mono_wasm_do_nothing ptr: 46277408 value: 0
  info: I 999
  info: mono_wasm_do_nothing ptr: 46277360 value: 999
Author: pavelsavara
Assignees: -
Labels:

arch-wasm, area-System.Runtime.InteropServices.JavaScript
Milestone: 7.0.0

@pavelsavara pavelsavara mentioned this issue Jun 29, 2022
Closed
@pavelsavara
Copy link
Member Author

@BrzVlad

@lewing
Copy link
Member

lewing commented Jul 8, 2022

cc @SamMonoRT

@BrzVlad
Copy link
Member

BrzVlad commented Jul 9, 2022

Closing this as duplicate of #37955

@BrzVlad BrzVlad closed this as completed Jul 9, 2022
@teo-tsirpanis teo-tsirpanis closed this as not planned Won't fix, can't repro, duplicate, stale Jul 11, 2022
@ghost ghost locked as resolved and limited conversation to collaborators Aug 10, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@BrzVlad BrzVlad

Labels
arch-wasm WebAssembly architecture area-System.Runtime.InteropServices.JavaScript
Projects
None yet
Milestone
7.0.0
Development

No branches or pull requests
4 participants
@lewing @pavelsavara @BrzVlad @teo-tsirpanis