Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[arm64] GCStress=C + JitStress=2 test failures in Vector tests #39581

Closed
BruceForstall opened this issue Jul 18, 2020 · 5 comments · Fixed by #39815
Closed

[arm64] GCStress=C + JitStress=2 test failures in Vector tests #39581

BruceForstall opened this issue Jul 18, 2020 · 5 comments · Fixed by #39815
Assignees
@echesakov
Labels
arch-arm64 area-CodeGen-coreclr CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI GCStress os-linux Linux OS (any supported distro)
Milestone
5.0.0

Comments

@BruceForstall
Copy link
Member

BruceForstall commented Jul 18, 2020 •
edited
Loading

These tests fail on Linux/arm64 with:

COMPlus_ReadyToRun=0
COMPlus_JitStress=2
COMPlus_TieredCompilation=0
COMPlus_GCStress=C

Tests:

Vector256_1_r
Vector256_1_ro

failures:

      Vector256.AllBitsSet(UInt16): RunReflectionScenario failed:
        result: (0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0)
      
      ERROR!!!-System.Exception: One or more scenarios did not complete as expected.

These failures occur in the runtime-coreclr gcstress-extra pipeline:

https://dev.azure.com/dnceng/public/_build/results?buildId=726589&view=ms.vss-test-web.build-test-results-tab

Related: #39576, #39579

category:testing
theme:vector-codegen
skill-level:intermediate
cost:medium
@BruceForstall BruceForstall added arch-arm64 os-linux Linux OS (any supported distro) GCStress area-CodeGen-coreclr CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI labels Jul 18, 2020
@BruceForstall BruceForstall added this to the 5.0.0 milestone Jul 18, 2020
@Dotnet-GitSync-Bot Dotnet-GitSync-Bot added the untriaged New issue has not been triaged by the area owner label Jul 18, 2020
BruceForstall added a commit to BruceForstall/runtime that referenced this issue Jul 18, 2020
@BruceForstall
Also disable Vector256_1_r/Vector_1_ro tests
3d779ba 
Issue: dotnet#39581
@BruceForstall
Copy link
Member Author

@tannergooding @CarolEidt @echesakovMSFT @kunalspathak

@BruceForstall BruceForstall removed the untriaged New issue has not been triaged by the area owner label Jul 18, 2020
BruceForstall added a commit that referenced this issue Jul 18, 2020
@BruceForstall
Disable Vector tests failing under GCStress (#39580)
8e7b5ae 
* Disable Vector tests failing under GCStress

Issues:
#39576
#39579

* Also disable Vector256_1_r/Vector_1_ro tests

Issue: #39581
@echesakov
Copy link
Contributor

The following is the minimal setup to reproduce the issue

root@e489b5beca1a:/opt/code/artifacts/tests/coreclr/Linux.arm64.Checked/JIT/HardwareIntrinsics/General/Vector256_1/Vector256_1_r# printenv | grep COMP
COMPlus_JitStressRange=755d5c0e
COMPlus_GCStress=C
COMPlus_TieredCompilation=0
COMPlus_JitStressModeNames=STRESS_TAILCALL

root@e489b5beca1a:/opt/code/artifacts/tests/coreclr/Linux.arm64.Checked/JIT/HardwareIntrinsics/General/Vector256_1/Vector256_1_r# $CORE_ROOT/corerun Vector256_1_r.dll AllBitsSet.UInt16
Beginning test case AllBitsSet.UInt16 at 7/22/2020 7:44:10 PM
Random seed: 20010415; set environment variable CORECLR_SEED to this value to repro

Beginning scenario: RunBasicScenario
Beginning scenario: RunReflectionScenario
Vector256.AllBitsSet(UInt16): RunReflectionScenario failed:
  result: (0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0)

ERROR!!!-System.Exception: One or more scenarios did not complete as expected.

Ending test case at 7/22/2020 7:44:20 PM

@echesakov
Copy link
Contributor

Got smaller repro without JitStress in #39815 (still need GCStress=C though)

@echesakov
Copy link
Contributor

The issue is understood, will submit a fix shortly

@echesakov
Copy link
Contributor

Posted description of the issue in the PR with the regression test #39815

@echesakov echesakov linked a pull request Jul 28, 2020 that will close this issue
Consider that retbuf arg can point to GC heap in fgCreateCallDispatcherAndGetResult() #39815
Merged
echesakov added a commit to echesakov/runtime that referenced this issue Jul 28, 2020
@echesakov
Add regression test for dotnet#39581
81252a1
Jacksondr5 pushed a commit to Jacksondr5/runtime that referenced this issue Aug 10, 2020
@BruceForstall @Jacksondr5
Disable Vector tests failing under GCStress (dotnet#39580)
b6f1cbe 
* Disable Vector tests failing under GCStress

Issues:
dotnet#39576
dotnet#39579

* Also disable Vector256_1_r/Vector_1_ro tests

Issue: dotnet#39581
@ghost ghost locked as resolved and limited conversation to collaborators Dec 8, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@echesakov echesakov

Labels
arch-arm64 area-CodeGen-coreclr CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI GCStress os-linux Linux OS (any supported distro)
Projects
None yet
Milestone
5.0.0
3 participants
@echesakov @BruceForstall @Dotnet-GitSync-Bot