Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[mono] Tracking: Implement System.Runtime.Intrinsics.Arm.Rdm #42322

Closed
10 tasks done
imhameed opened this issue Sep 16, 2020 · 5 comments
Closed
10 tasks done

[mono] Tracking: Implement System.Runtime.Intrinsics.Arm.Rdm #42322

imhameed opened this issue Sep 16, 2020 · 5 comments
Assignees
@imhameed
Labels
area-Codegen-LLVM-mono runtime-mono specific to the Mono runtime tracking This issue is tracking the completion of other related issues.
Milestone
6.0.0

Comments

@imhameed
Copy link
Contributor

imhameed commented Sep 16, 2020 •
edited
Loading

System.Runtime.Intrinsics.Arm.Rdm:

  • IsSupported
  • MultiplyRoundedDoublingAndAddSaturateHigh
  • MultiplyRoundedDoublingAndSubtractSaturateHigh
  • MultiplyRoundedDoublingBySelectedScalarAndAddSaturateHigh
  • MultiplyRoundedDoublingBySelectedScalarAndSubtractSaturateHigh

System.Runtime.Intrinsics.Arm.Rdm.Arm64:

  • IsSupported
  • MultiplyRoundedDoublingAndAddSaturateHighScalar
  • MultiplyRoundedDoublingAndSubtractSaturateHighScalar
  • MultiplyRoundedDoublingScalarBySelectedScalarAndAddSaturateHigh
  • MultiplyRoundedDoublingScalarBySelectedScalarAndSubtractSaturateHigh
@imhameed imhameed added runtime-mono specific to the Mono runtime area-Codegen-LLVM-mono labels Sep 16, 2020
@imhameed imhameed added this to the 6.0.0 milestone Sep 16, 2020
@Dotnet-GitSync-Bot Dotnet-GitSync-Bot added the untriaged New issue has not been triaged by the area owner label Sep 16, 2020
@ghost
Copy link

ghost commented Sep 16, 2020

Tagging subscribers to this area:
See info in area-owners.md if you want to be subscribed.

@imhameed imhameed removed the untriaged New issue has not been triaged by the area owner label Sep 16, 2020
@imhameed imhameed mentioned this issue Oct 5, 2020
Open
58 tasks
@imhameed imhameed added the tracking This issue is tracking the completion of other related issues. label Oct 28, 2020
@mihir-b-shah
Copy link
Contributor

Hi I was interested in working on this issue, I was wondering are there any tests available for this or should I be writing my own corresponding tests? Thank you!

@imhameed
Copy link
Contributor Author

Hi @mihir-b-shah,

Awesome. There are tests available but they are currently disabled. The existing tests are located here:

Other intrinsics-on-Mono work is being done right now, and by looking at some of these commits you should be able to get a feel for what you'll need to do. Here's an example:

@SamMonoRT
Copy link
Member

Need #48475 to implement a subset of these

@imhameed imhameed assigned imhameed and unassigned CoffeeFlux Mar 15, 2021
@imhameed imhameed mentioned this issue Mar 17, 2021
Merged
imhameed added a commit that referenced this issue Jun 24, 2021
@imhameed
[mono] Implement Rdm and Dp (#49737)
4aeef0d 
See #42322 and
#42280.

Tested manually on an arm64 Linux VM running on an M1 Mac Mini. Does not
enable RDM or DP when AOT-compiling the associated runtime tests; our CI
hardware doesn't support these extensions yet.
@imhameed
Copy link
Contributor Author

Implemented in #49737.

@ghost ghost locked as resolved and limited conversation to collaborators Jul 24, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@imhameed imhameed

Labels
area-Codegen-LLVM-mono runtime-mono specific to the Mono runtime tracking This issue is tracking the completion of other related issues.
Projects
None yet
Milestone
6.0.0
Development

No branches or pull requests
5 participants
@CoffeeFlux @Dotnet-GitSync-Bot @SamMonoRT @mihir-b-shah @imhameed