Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove ! from Microsoft.Extensions.FileProviders.Physical #57518

Open
2 tasks
maxkoshevoi opened this issue Aug 16, 2021 · 2 comments
Open
2 tasks

Remove ! from Microsoft.Extensions.FileProviders.Physical #57518

maxkoshevoi opened this issue Aug 16, 2021 · 2 comments
Labels
area-Extensions-FileSystem
Milestone
Future

Comments

@maxkoshevoi
Copy link
Contributor

maxkoshevoi commented Aug 16, 2021 •
edited
Loading

Description

This is a blanket issue for all ! operations that were added in #57409
They should be removed or reviewed.

Left to be fixed/reviewed:

  • PhysicalFileProvider.FileWatcher LazyInitializer.EnsureInitialized. Possible fix - remove _fileWatcherInitialized field.
  • PollingFileChangeToken and PollingWildCardChangeToken IChangeToken.RegisterChangeCallback
@dotnet-issue-labeler dotnet-issue-labeler bot added the untriaged New issue has not been triaged by the area owner label Aug 16, 2021
@dotnet-issue-labeler
Copy link

I couldn't figure out the best area label to add to this issue. If you have write-permissions please help me learn by adding exactly one area label.

@maxkoshevoi maxkoshevoi changed the title [WIP] Remove ! from Microsoft.Extensions.FileProviders.Physical Remove ! from Microsoft.Extensions.FileProviders.Physical Aug 16, 2021
maxkoshevoi added a commit to maxkoshevoi/runtime that referenced this issue Aug 16, 2021
@maxkoshevoi
Avoid product changes
0f10cd6 
Issue to remove/review "!": dotnet#57518
@ghost
Copy link

ghost commented Aug 17, 2021

Tagging subscribers to this area: @maryamariyan, @dotnet/area-extensions-filesystem
See info in area-owners.md if you want to be subscribed.

Issue Details

Description

This is a blanket issue for all ! operations that were added in #57409
They should be removed or reviewed.

Left to be fixed/reviewed:

  • PhysicalFileProvider.FileWatcher LazyInitializer.EnsureInitialized. Possible fix - remove _fileWatcherInitialized field.
  • PollingFileChangeToken and PollingWildCardChangeToken IChangeToken.RegisterChangeCallback
Author: maxkoshevoi
Assignees: -
Labels:

untriaged, area-Extensions-FileSystem
Milestone: -

@adamsitnik adamsitnik removed the untriaged New issue has not been triaged by the area owner label Aug 17, 2021
@adamsitnik adamsitnik added this to the Future milestone Aug 17, 2021
@maxkoshevoi maxkoshevoi mentioned this issue Aug 26, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
area-Extensions-FileSystem
Projects
None yet
Milestone
Future
Development

No branches or pull requests
3 participants
@adamsitnik @maxkoshevoi @jeffschwMSFT