Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[wasm] Wasm.Build.Tests remove the *emsdk* run #58159

Closed
radical opened this issue Aug 26, 2021 · 1 comment · Fixed by #69519
Closed

[wasm] Wasm.Build.Tests remove the *emsdk* run #58159

radical opened this issue Aug 26, 2021 · 1 comment · Fixed by #69519
Assignees
@radical
Labels
arch-wasm WebAssembly architecture area-Build-mono
Milestone
7.0.0

Comments

@radical
Copy link
Member

radical commented Aug 26, 2021 •
edited
Loading

  • right now, for Wasm.Build.Tests, we run tests in two setups:
    1. workload installed
    2. workload not installed, and workload resolver disabled, and EMSDK used via the LocalBuild stuff.
  • Library, and runtime tests already exercise the InTree, and LocalBuild(with aot) targets
  • it would be more useful to run specific tests with the same sdk, but no workload installed
@radical radical added arch-wasm WebAssembly architecture area-Build-mono labels Aug 26, 2021
@radical radical added this to the 7.0.0 milestone Aug 26, 2021
@radical radical self-assigned this Aug 26, 2021
@dotnet-issue-labeler dotnet-issue-labeler bot added the untriaged New issue has not been triaged by the area owner label Aug 26, 2021
@ghost
Copy link

ghost commented Aug 26, 2021

Tagging subscribers to 'arch-wasm': @lewing
See info in area-owners.md if you want to be subscribed.

Issue Details
  • right now, for Wasm.Build.Tests, we run tests in two setups: 1. workload installed; 2. workload not installed, and workload resolver disabled, and EMSDK used via the LocalBuild stuff.
  • Library, and runtime tests already exercise the InTree, and LocalBuild(with aot) targets
  • it would be more useful to run specific tests with the same sdk, but no workload installed
Author: radical
Assignees: radical
Labels:

arch-wasm, area-Build-mono
Milestone: 7.0.0

@radical radical removed the untriaged New issue has not been triaged by the area owner label Aug 26, 2021
@radical radical mentioned this issue May 19, 2022
Merged
@ghost ghost added the in-pr There is an active PR which will close this issue when it is merged label May 19, 2022
radical added a commit that referenced this issue May 20, 2022
@radical
[wasm] CI build improvements (#69519)
e4ac5cd 
- Run all the debugger tests in one helix job, because most of them take a couple of minutes to run. And this would avoid the overhead of individual helix jobs

- Add a no-workloads variant for `Wasm.Build.Tests`, instead of `EMSDK`
  - This replaces the job that used `WasmApp.LocalBuild*` stuff to build
with a `EMSDK` checkout. That case already gets tested with library tests.
   - The `EMSDK` case had been disabled recently due to an Arcade issue
  - Since we have very few tests to run for the noworkloads case, they are
all run in a single helix work item.

Fixes #58159
Fixes #67887 (by completely removing the `EMSDK` run)
@ghost ghost removed the in-pr There is an active PR which will close this issue when it is merged label May 20, 2022
@ghost ghost locked as resolved and limited conversation to collaborators Jun 20, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@radical radical

Labels
arch-wasm WebAssembly architecture area-Build-mono
Projects
None yet
Milestone
7.0.0
Development

Successfully merging a pull request may close this issue.

[wasm] CI build improvements radical/runtime
1 participant
@radical