-
Notifications
You must be signed in to change notification settings - Fork 4.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Android] System.Security.Cryptography.X509Certificates ExportCertificatePems_MultiCert Failure #59777
Comments
Tagging subscribers to this area: @bartonjs, @vcsjones, @krwq, @GrabYourPitchforks Issue Details
Build: https://dev.azure.com/dnceng/public/_build/results?buildId=1393183&view=logs&j=b6e5d97f-d4f8-506b-9e47-e3e32385754a&t=94ce2805-f3e2-5f9a-1d92-0da5613f733d
|
Hm, okay. Do Android tests not run as part of CI? Why was this green and got merged? |
@vcsjones They are on CI, but they're non-blocking and show up in runtime-staging because of flakey reasons such as infrastructure failures, hitting a bad machine on the osx hosted pools, etc. As long as the build/lane completes its marked green on the github UI, but on close inspection by clicking the runtime-staging lane https://github.com/dotnet/runtime/pull/59674/checks?check_run_id=3740236485 the error is shown but again non-blocking. |
Android exports PKCS7 certificates in a different order, and the xunit assertion is sensitive to order. So we sort them first. Fixes #59777.
Build: https://dev.azure.com/dnceng/public/_build/results?buildId=1393183&view=logs&j=b6e5d97f-d4f8-506b-9e47-e3e32385754a&t=94ce2805-f3e2-5f9a-1d92-0da5613f733d
Log: https://helixre8s23ayyeko0k025g8.blob.core.windows.net/dotnet-runtime-refs-pull-59762-merge-4055e4601c8e44dda7/System.Security.Cryptography.X509Certificates.Tests/1/console.99823d73.log?sv=2019-07-07&se=2021-10-19T18%3A38%3A09Z&sr=c&sp=rl&sig=LEPDic2W76gebkX3PdhWIyGcR4xrOqI8dDvJ26iXiN8%3D
cc/ @vcsjones @bartonjs
The text was updated successfully, but these errors were encountered: